Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2085)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-name.html

Issue 2642123003: Bluetooth: Make maximum possible name filter 248 bytes, not 240 (Closed)
Patch Set: Change all NotFoundErrors to TypeErrors Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-name.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-name.html b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-name.html
index 7a8f84368e123d9680912b48bbae8a3bd72a54b6..c4e3fca5c0ef8f21e9d09f1c0607b08de104eb7d 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-name.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-name.html
@@ -5,15 +5,13 @@
<script>
'use strict';
promise_test(() => {
- const name_too_long = generate_string(241, 'a');
+ const name_too_long = generate_string(249, 'a');
return assert_promise_rejects_with_message(
requestDeviceWithKeyDown({filters: [{name: name_too_long}]}),
new DOMException(
'Failed to execute \'requestDevice\' on \'Bluetooth\': ' +
- 'A \'name\' or \'namePrefix\' longer than 240 bytes ' +
- 'results in no devices being found, because a device can\'t ' +
- 'acquire a name longer than 240 bytes.',
- 'NotFoundError'),
- 'Device name longer than 240');
-}, 'A device name longer than 240 bytes must reject.');
+ 'A device name can\'t be longer than 248 bytes.',
+ 'TypeError'),
+ 'Device name longer than 248');
+}, 'A device name longer than 248 bytes must reject.');
</script>

Powered by Google App Engine
This is Rietveld 408576698