Bluetooth: Make maximum possible name filter 248 bytes, not 240

content/browser/bluetooth/bluetooth_device_chooser_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/bluetooth/bluetooth_device_chooser_controller.h"
 
 #include <set>
 #include <string>
 #include <unordered_set>
 
@@ skipping 61 matching lines @@
 const int k60thPercentileRSSI = -55;
 const int k80thPercentileRSSI = -47;
 
 }  // namespace
 
 namespace content {
 
 bool BluetoothDeviceChooserController::use_test_scan_duration_ = false;
 
 namespace {
-// Max length of device name in filter. A name coming from an adv packet
-// is max 29 bytes (adv packet max size 31 bytes - 2 byte length field),
-// but the name can also be acquired via gap.device_name, so it is limited
-// to the max EIR packet size of 240 bytes. See Core Spec 5.0, vol 3, C, 8.1.2.
-constexpr size_t kMaxLengthForDeviceName = 240;
+// Max length of device name in filter. Bluetooth 5.0 3.C.3.2.2.3 states that
+// the maximum device name length is 248 bytes (UTF-8 encoded).
+constexpr size_t kMaxLengthForDeviceName = 248;
 
 // The duration of a Bluetooth Scan in seconds.
 constexpr int kScanDuration = 60;
 constexpr int kTestScanDuration = 0;
 
 void LogRequestDeviceOptions(
     const blink::mojom::WebBluetoothRequestDeviceOptionsPtr& options) {
   DVLOG(1) << "requestDevice called with the following filters: ";
   DVLOG(1) << "acceptAllDevices: " << options->accept_all_devices;
 
@@ skipping 522 matching lines @@
 
 void BluetoothDeviceChooserController::PostErrorCallback(
     blink::mojom::WebBluetoothResult error) {
   if (!base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE, base::Bind(error_callback_, error))) {
     LOG(WARNING) << "No TaskRunner.";
   }
 }
 
 }  // namespace content