Add initial support for parts to the incremental kernel generator.

Add initial support for parts to the incremental kernel generator.

R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/c04ba40745c54c2e010a3ab2fbaa034fd06f9389

[Paul Berry, 2017-01-19 19:06:26]

paulberry@google.com changed reviewers:
+ danrubel@google.com

[danrubel, 2017-01-19 20:06:39]

LGTM with comment to do with as you see fit.

https://codereview.chromium.org/2642083003/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart (right):

https://codereview.chromium.org/2642083003/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart:269: var
absoluteUri = containingSource == null
Is absoluteUri dynamic? IOW, will absoluteUri be a String if containingSource is
null, but a Uri if containingSource is not null? That feels a little awkward too
me. Perhaps change

    containingSource.uri.resolve(containedUri);
to
    containingSource.uri.resolve(containedUri).toString();

so that absoluteUri is always a string?

It would also be nicer to pass around instances of Uri rather than String, then
forUri(...) can accept a Uri rather than always having to call Uri.parse.  

That said there may be larger API issues compelling you to pass around Strings
rather than Uris, so entirely up to you how this should be handled.

[Paul Berry, 2017-01-19 20:29:46]

https://codereview.chromium.org/2642083003/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart (right):

https://codereview.chromium.org/2642083003/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart:269: var
absoluteUri = containingSource == null
On 2017/01/19 20:06:39, danrubel wrote:
> Is absoluteUri dynamic? IOW, will absoluteUri be a String if containingSource
is
> null, but a Uri if containingSource is not null? That feels a little awkward
too
> me. Perhaps change
> 
>     containingSource.uri.resolve(containedUri);
> to
>     containingSource.uri.resolve(containedUri).toString();
> 
> so that absoluteUri is always a string?
> 
> It would also be nicer to pass around instances of Uri rather than String,
then
> forUri(...) can accept a Uri rather than always having to call Uri.parse.  
> 
> That said there may be larger API issues compelling you to pass around Strings
> rather than Uris, so entirely up to you how this should be handled.

Whoops, thanks for catching this.  I took your suggestion of changing to
`containingSource.uri.resolve(containedUri).toString()`.

You guessed correctly that there are larger API issues compelling me to pass
around Strings.  Specifically the fact that this is a proxy object to interface
with existing analyzer code that deals with strings.  In the long run I hope to
get rid of these proxies entirely, and in the code I'm writing to replace them,
I'm trying to use URIs more consistently.

[Paul Berry, 2017-01-19 20:32:33]

Description was changed from

==========
Add initial support for parts to the incremental kernel generator.
==========

to

==========
Add initial support for parts to the incremental kernel generator.

R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c04ba40745c54c2e010a3ab2fbaa034fd06f9389
==========

[Paul Berry, 2017-01-19 20:32:34]

Committed patchset #1 (id:1) manually as
c04ba40745c54c2e010a3ab2fbaa034fd06f9389 (presubmit successful).