Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2642063003: Use entities in class_stub_generator. (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -145 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +11 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 6 chunks +12 lines, -21 lines 1 comment Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 chunk +7 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 1 chunk +6 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 1 chunk +8 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +7 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_generator.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 2 chunks +9 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +14 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 1 chunk +7 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/switch_continue_analysis.dart View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-19 15:19:51 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2642063003/diff/1/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right): https://codereview.chromium.org/2642063003/diff/1/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart#newcode12 pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:12: import '../js_backend/js_backend.dart' show JavaScriptBackend, Namer; I see that ...
3 years, 11 months ago (2017-01-19 16:44:42 UTC) #3
Johnni Winther
3 years, 11 months ago (2017-01-20 08:22:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b2fa02328aeb71b9eec3b3cc748e5c78ea6adb20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698