Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2642033002: Implements CSSPropertyAPI for the d property (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index b47f79a5368717d900c779f3e64d61bbbe5332ea..808125bc8656ab63ccd4641c99068a44e3ef1df2 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -22,7 +22,6 @@
#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSInheritedValue.h"
#include "core/css/CSSInitialValue.h"
-#include "core/css/CSSPathValue.h"
#include "core/css/CSSPendingSubstitutionValue.h"
#include "core/css/CSSPrimitiveValueMappings.h"
#include "core/css/CSSQuadValue.h"
@@ -44,7 +43,6 @@
#include "core/css/properties/CSSPropertyDescriptor.h"
#include "core/frame/UseCounter.h"
#include "core/layout/LayoutTheme.h"
-#include "core/svg/SVGPathUtilities.h"
#include "wtf/text/StringBuilder.h"
#include <memory>
@@ -1247,36 +1245,12 @@ static CSSValue* consumeContain(CSSParserTokenRange& range) {
return list;
}
-static CSSValue* consumePath(CSSParserTokenRange& range) {
- // FIXME: Add support for <url>, <basic-shape>, <geometry-box>.
- if (range.peek().functionId() != CSSValuePath)
- return nullptr;
-
- CSSParserTokenRange functionRange = range;
- CSSParserTokenRange functionArgs = consumeFunction(functionRange);
-
- if (functionArgs.peek().type() != StringToken)
- return nullptr;
- String pathString =
- functionArgs.consumeIncludingWhitespace().value().toString();
-
- std::unique_ptr<SVGPathByteStream> byteStream = SVGPathByteStream::create();
- if (buildByteStreamFromString(pathString, *byteStream) !=
- SVGParseStatus::NoError ||
- !functionArgs.atEnd())
- return nullptr;
-
- range = functionRange;
- if (byteStream->isEmpty())
- return CSSIdentifierValue::create(CSSValueNone);
- return CSSPathValue::create(std::move(byteStream));
-}
-
static CSSValue* consumePathOrNone(CSSParserTokenRange& range) {
CSSValueID id = range.peek().id();
if (id == CSSValueNone)
return consumeIdent(range);
+ // FIXME: Add support for <url>, <basic-shape>, <geometry-box>.
return consumePath(range);
}
@@ -3152,8 +3126,6 @@ const CSSValue* CSSPropertyParser::parseSingleValue(
return consumeTextDecorationLine(m_range);
case CSSPropertyOffsetAnchor:
return consumeOffsetAnchor(m_range, m_context->mode());
- case CSSPropertyD:
- return consumePathOrNone(m_range);
case CSSPropertyOffsetPath:
return consumeOffsetPath(
m_range, m_context,

Powered by Google App Engine
This is Rietveld 408576698