Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2093)

Unified Diff: chrome/browser/android/webapk/webapk_installer.h

Issue 2641973003: Implement server-suggested update check backoff (Closed)
Patch Set: 2 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_installer.h
diff --git a/chrome/browser/android/webapk/webapk_installer.h b/chrome/browser/android/webapk/webapk_installer.h
index bfb925f0d7c94f63eb2d7b84d07cb2affb65d77f..fd7060bc87ebd3f53688ac02462a509be6c6feed 100644
--- a/chrome/browser/android/webapk/webapk_installer.h
+++ b/chrome/browser/android/webapk/webapk_installer.h
@@ -43,7 +43,9 @@ class WebApkInstaller : public net::URLFetcherDelegate {
// Parameters:
// - whether the process succeeds.
// - the package name of the WebAPK.
- using FinishCallback = base::Callback<void(bool, const std::string&)>;
+ // - true if Chrome received a "don't update so frequently" directive from the
+ // WebAPK server.
pkotwicz 2017/02/14 00:15:13 Nit: "don't update so frequently" -> "request upda
Xi Han 2017/02/14 22:25:47 Done.
+ using FinishCallback = base::Callback<void(bool, const std::string&, bool)>;
dominickn 2017/02/14 04:13:34 Urgh this bool string bool argument ordering is no
Xi Han 2017/02/14 22:25:47 Done.
~WebApkInstaller() override;
@@ -270,6 +272,9 @@ class WebApkInstaller : public net::URLFetcherDelegate {
// WebAPK package name.
std::string webapk_package_;
+ // Whether the server wants the WebAPK to request updates less frequently.
+ bool less_updates_;
dominickn 2017/02/14 04:13:34 relax_updates_
Xi Han 2017/02/14 22:25:47 Done.
+
// WebAPK version code.
int webapk_version_;

Powered by Google App Engine
This is Rietveld 408576698