Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: third_party/WebKit/Source/core/events/EventDispatcher.cpp

Issue 2641953006: Remove setting cancelBubble to false. (Closed)
Patch Set: update Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/EventDispatcher.cpp
diff --git a/third_party/WebKit/Source/core/events/EventDispatcher.cpp b/third_party/WebKit/Source/core/events/EventDispatcher.cpp
index eb277c1b089197810074fd25a45f178e3805534e..c89649f3c44697088bd24e4a20ce8274dc907697 100644
--- a/third_party/WebKit/Source/core/events/EventDispatcher.cpp
+++ b/third_party/WebKit/Source/core/events/EventDispatcher.cpp
@@ -218,11 +218,6 @@ inline void EventDispatcher::dispatchEventAtBubbling() {
} else if (m_event->bubbles() && !m_event->cancelBubble()) {
m_event->setEventPhase(Event::kBubblingPhase);
} else {
- if (m_event->bubbles() && m_event->cancelBubble() &&
- eventContext.node() &&
- eventContext.node()->hasEventListeners(m_event->type()))
- UseCounter::count(eventContext.node()->document(),
- UseCounter::EventCancelBubbleAffected);
continue;
}
eventContext.handleLocalEvents(*m_event);
@@ -232,17 +227,6 @@ inline void EventDispatcher::dispatchEventAtBubbling() {
if (m_event->bubbles() && !m_event->cancelBubble()) {
m_event->setEventPhase(Event::kBubblingPhase);
m_event->eventPath().windowEventContext().handleLocalEvents(*m_event);
- } else if (m_event->bubbles() &&
- m_event->eventPath().windowEventContext().window() &&
- m_event->eventPath()
- .windowEventContext()
- .window()
- ->hasEventListeners(m_event->type())) {
- UseCounter::count(m_event->eventPath()
- .windowEventContext()
- .window()
- ->getExecutionContext(),
- UseCounter::EventCancelBubbleAffected);
}
}

Powered by Google App Engine
This is Rietveld 408576698