Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: third_party/WebKit/Source/core/events/Event.h

Issue 2641953006: Remove setting cancelBubble to false. (Closed)
Patch Set: update Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/Event.h
diff --git a/third_party/WebKit/Source/core/events/Event.h b/third_party/WebKit/Source/core/events/Event.h
index b5d4bb51e58737c830b4bef5c5dda35052ad9897..d85ac87f7b0552fdaace6da1b95e6fbfb5b5cf22 100644
--- a/third_party/WebKit/Source/core/events/Event.h
+++ b/third_party/WebKit/Source/core/events/Event.h
@@ -199,7 +199,7 @@ class CORE_EXPORT Event : public GarbageCollectedFinalized<Event>,
void setDefaultHandled() { m_defaultHandled = true; }
bool cancelBubble(ExecutionContext* = nullptr) const {
- return m_cancelBubble;
+ return propagationStopped();
}
void setCancelBubble(ExecutionContext*, bool);
@@ -285,7 +285,6 @@ class CORE_EXPORT Event : public GarbageCollectedFinalized<Event>,
unsigned m_immediatePropagationStopped : 1;
unsigned m_defaultPrevented : 1;
unsigned m_defaultHandled : 1;
- unsigned m_cancelBubble : 1;
unsigned m_wasInitialized : 1;
unsigned m_isTrusted : 1;

Powered by Google App Engine
This is Rietveld 408576698