Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 2641953003: [pattern rewriter] Only desugar to call %ToName on computed properties (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[pattern rewriter] Only desugar to call %ToName on computed properties Convert strings to numbers if possible in the runtime call and store in excluded property list. BUG=v8:5549 patch from issue 2644723002 at patchset 1 (http://crrev.com/2644723002#ps1)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -22 lines) Patch
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 2 chunks +15 lines, -13 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/object-rest-basic.js View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-19 08:50:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641953003/1
3 years, 11 months ago (2017-01-19 08:50:50 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-19 08:52:19 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 08:52:19 UTC) #4
Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/19504)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

Powered by Google App Engine
This is Rietveld 408576698