Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Side by Side Diff: src/compiler/raw-machine-assembler.cc

Issue 2641863002: [csa] Fix the bound & used condition check for RawMachineLabel and CodeAssemblerLabel. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/code-assembler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/raw-machine-assembler.h" 5 #include "src/compiler/raw-machine-assembler.h"
6 6
7 #include "src/compiler/node-properties.h" 7 #include "src/compiler/node-properties.h"
8 #include "src/compiler/pipeline.h" 8 #include "src/compiler/pipeline.h"
9 #include "src/compiler/scheduler.h" 9 #include "src/compiler/scheduler.h"
10 #include "src/objects-inl.h" 10 #include "src/objects-inl.h"
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 return node; 325 return node;
326 } 326 }
327 327
328 Node* RawMachineAssembler::MakeNode(const Operator* op, int input_count, 328 Node* RawMachineAssembler::MakeNode(const Operator* op, int input_count,
329 Node* const* inputs) { 329 Node* const* inputs) {
330 // The raw machine assembler nodes do not have effect and control inputs, 330 // The raw machine assembler nodes do not have effect and control inputs,
331 // so we disable checking input counts here. 331 // so we disable checking input counts here.
332 return graph()->NewNodeUnchecked(op, input_count, inputs); 332 return graph()->NewNodeUnchecked(op, input_count, inputs);
333 } 333 }
334 334
335 RawMachineLabel::~RawMachineLabel() { DCHECK(bound_ || !used_); } 335 RawMachineLabel::~RawMachineLabel() {
336 // If this DCHECK fails, it means that the label has been bound but it's not
337 // used, or the opposite. This would cause the register allocator to crash.
338 DCHECK_EQ(bound_, used_);
339 }
336 340
337 } // namespace compiler 341 } // namespace compiler
338 } // namespace internal 342 } // namespace internal
339 } // namespace v8 343 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/code-assembler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698