Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2641833004: Don't crash on missing dart: URI. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fe_integration
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M pkg/fasta/lib/src/translate_uri.dart View 2 chunks +3 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
When returning null, the code using this method reports an error.
3 years, 11 months ago (2017-01-19 09:51:23 UTC) #2
Johnni Winther
lgtm
3 years, 11 months ago (2017-01-19 11:46:49 UTC) #3
ahe
3 years, 11 months ago (2017-01-19 12:04:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2fbbee55f8abbf931747ef7de29704c9f933d6a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698