Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: Source/core/rendering/svg/RenderSVGModelObject.cpp

Issue 264183002: RAL: Eliminate n^2 walk to find repaint containers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: With less asserts :( Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2009, Google Inc. All rights reserved. 2 * Copyright (c) 2009, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 return false; 117 return false;
118 } 118 }
119 119
120 // The SVG addFocusRingRects() method adds rects in local coordinates so the def ault absoluteFocusRingQuads 120 // The SVG addFocusRingRects() method adds rects in local coordinates so the def ault absoluteFocusRingQuads
121 // returns incorrect values for SVG objects. Overriding this method provides acc ess to the absolute bounds. 121 // returns incorrect values for SVG objects. Overriding this method provides acc ess to the absolute bounds.
122 void RenderSVGModelObject::absoluteFocusRingQuads(Vector<FloatQuad>& quads) 122 void RenderSVGModelObject::absoluteFocusRingQuads(Vector<FloatQuad>& quads)
123 { 123 {
124 quads.append(localToAbsoluteQuad(FloatQuad(repaintRectInLocalCoordinates())) ); 124 quads.append(localToAbsoluteQuad(FloatQuad(repaintRectInLocalCoordinates())) );
125 } 125 }
126 126
127 void RenderSVGModelObject::repaintTreeAfterLayout() 127 void RenderSVGModelObject::repaintTreeAfterLayout(const RenderLayerModelObject& repaintContainer)
128 { 128 {
129 // Note: This is a reduced version of RenderBox::repaintTreeAfterLayout(). 129 // Note: This is a reduced version of RenderBox::repaintTreeAfterLayout().
130 // FIXME: Should share code with RenderBox::repaintTreeAfterLayout(). 130 // FIXME: Should share code with RenderBox::repaintTreeAfterLayout().
131 ASSERT(RuntimeEnabledFeatures::repaintAfterLayoutEnabled()); 131 ASSERT(RuntimeEnabledFeatures::repaintAfterLayoutEnabled());
132 ASSERT(!needsLayout()); 132 ASSERT(!needsLayout());
133 133
134 if (!shouldCheckForInvalidationAfterLayout()) 134 if (!shouldCheckForInvalidationAfterLayout())
135 return; 135 return;
136 136
137 LayoutStateDisabler layoutStateDisabler(*this); 137 LayoutStateDisabler layoutStateDisabler(*this);
138 138
139 const LayoutRect oldRepaintRect = previousRepaintRect(); 139 const LayoutRect oldRepaintRect = previousRepaintRect();
140 const LayoutPoint oldPositionFromRepaintContainer = previousPositionFromRepa intContainer(); 140 const LayoutPoint oldPositionFromRepaintContainer = previousPositionFromRepa intContainer();
141 const RenderLayerModelObject* repaintContainer = containerForRepaint(); 141 const RenderLayerModelObject& newRepaintContainer = *containerForRepaint();
142 setPreviousRepaintRect(clippedOverflowRectForRepaint(repaintContainer)); 142 setPreviousRepaintRect(clippedOverflowRectForRepaint(&newRepaintContainer));
143 setPreviousPositionFromRepaintContainer(positionFromRepaintContainer(repaint Container)); 143 setPreviousPositionFromRepaintContainer(positionFromRepaintContainer(&newRep aintContainer));
144 144
145 // If we are set to do a full repaint that means the RenderView will be 145 // If we are set to do a full repaint that means the RenderView will be
146 // invalidated. We can then skip issuing of invalidations for the child 146 // invalidated. We can then skip issuing of invalidations for the child
147 // renderers as they'll be covered by the RenderView. 147 // renderers as they'll be covered by the RenderView.
148 if (view()->doingFullRepaint()) { 148 if (view()->doingFullRepaint()) {
149 RenderObject::repaintTreeAfterLayout(); 149 RenderObject::repaintTreeAfterLayout(newRepaintContainer);
150 return; 150 return;
151 } 151 }
152 152
153 const LayoutRect& newRepaintRect = previousRepaintRect(); 153 const LayoutRect& newRepaintRect = previousRepaintRect();
154 const LayoutPoint& newPositionFromRepaintContainer = previousPositionFromRep aintContainer(); 154 const LayoutPoint& newPositionFromRepaintContainer = previousPositionFromRep aintContainer();
155 repaintAfterLayoutIfNeeded(containerForRepaint(), 155 repaintAfterLayoutIfNeeded(containerForRepaint(),
156 shouldDoFullRepaintAfterLayout(), oldRepaintRect, oldPositionFromRepaint Container, &newRepaintRect, &newPositionFromRepaintContainer); 156 shouldDoFullRepaintAfterLayout(), oldRepaintRect, oldPositionFromRepaint Container, &newRepaintRect, &newPositionFromRepaintContainer);
157 157
158 RenderObject::repaintTreeAfterLayout(); 158 RenderObject::repaintTreeAfterLayout(newRepaintContainer);
159 } 159 }
160 160
161 } // namespace WebCore 161 } // namespace WebCore
OLDNEW
« Source/core/rendering/RenderView.h ('K') | « Source/core/rendering/svg/RenderSVGModelObject.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698