url/url_canon.h - Issue 2641823004: [url] Reserve size in a smarter way to account for pre-allocated buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/url_canon.h

Issue 2641823004: [url] Reserve size in a smarter way to account for pre-allocated buffers (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: url/url_canon.h

diff --git a/url/url_canon.h b/url/url_canon.h

index ff66c6e3086172730eec5112cd4a8899d1a8afcc..d093f359fe18f244184b1163311b6fa8b4ac2e97 100644

--- a/url/url_canon.h

+++ b/url/url_canon.h

@@ -118,8 +118,9 @@ class CanonOutputT {

}

void ReserveSizeIfNeeded(int estimated_size) {

+ // Reserve a bit extra to account for escaped chars.

if (estimated_size > buffer_len_)

- Resize(estimated_size);

+ Resize(estimated_size + 8);

}

protected:

« no previous file with comments | « no previous file | url/url_canon_relative.cc » ('j') | no next file with comments »