Change js_emitter parts into libraries

Change js_emitter parts into libraries

- to make it easier to discover dependencies for refactoring.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/7a7d767f6d434224fec929746271ec8d91a4f936

[Johnni Winther, 2017-01-19 14:09:47]

Description was changed from

==========
Mark js_emitter parts libraries

- to make it easier to discover dependencies for refactoring.
==========

to

==========
Change js_emitter parts into libraries

- to make it easier to discover dependencies for refactoring.
==========

[Johnni Winther, 2017-01-19 14:09:56]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-19 16:41:41]

lgtm

https://codereview.chromium.org/2641813006/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right):

https://codereview.chromium.org/2641813006/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:12: ClassElement,
indentation seems odd here, missing darftmt? (same in the other files)

https://codereview.chromium.org/2641813006/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/js_emitter.dart (right):

https://codereview.chromium.org/2641813006/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/js_emitter.dart:23: part 'helpers.dart';
such a lonely part :( 

Looking into it, it seems this is only used in program_builder/*, maybe move the
helper method to program_builder.dart?

There is an import from dart2js_incremental that shows the
computeMixinApplication function, but it seems unused.

[Siggi Cherem (dart-lang), 2017-01-19 16:45:17]

https://codereview.chromium.org/2641813006/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right):

https://codereview.chromium.org/2641813006/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:12: ClassElement,
On 2017/01/19 16:41:41, Siggi Cherem (dart-lang) wrote:
> indentation seems odd here, missing darftmt? (same in the other files)

I see that you are fixing this in a subsequent CL, so feel free to leave it as
it is to avoid rebase churn

[Johnni Winther, 2017-01-20 08:14:23]

Description was changed from

==========
Change js_emitter parts into libraries

- to make it easier to discover dependencies for refactoring.
==========

to

==========
Change js_emitter parts into libraries

- to make it easier to discover dependencies for refactoring.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7a7d767f6d434224fec929746271ec8d91a4f936
==========

[Johnni Winther, 2017-01-20 08:14:24]

Committed patchset #1 (id:1) manually as
7a7d767f6d434224fec929746271ec8d91a4f936 (presubmit successful).