Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: chrome/browser/ui/views/session_crashed_bubble_view.h

Issue 2641813004: Convert SessionCrashedBubbleView to use the new navigation callbacks. (Closed)
Patch Set: add comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/session_crashed_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/session_crashed_bubble_view.h
diff --git a/chrome/browser/ui/views/session_crashed_bubble_view.h b/chrome/browser/ui/views/session_crashed_bubble_view.h
index 93ad639b0a471f1dc6853a4fd1c64247098b70c6..9779ce20c58f4cd5bdda6d4b4762b9a5a33900a1 100644
--- a/chrome/browser/ui/views/session_crashed_bubble_view.h
+++ b/chrome/browser/ui/views/session_crashed_bubble_view.h
@@ -75,9 +75,6 @@ class SessionCrashedBubbleView : public SessionCrashedBubble,
int event_flags) override;
// content::WebContentsObserver methods.
- void DidStartNavigationToPendingEntry(
- const GURL& url,
- content::ReloadType reload_type) override;
void DidFinishLoad(content::RenderFrameHost* render_frame_host,
const GURL& validated_url) override;
void WasShown() override;
@@ -114,8 +111,9 @@ class SessionCrashedBubbleView : public SessionCrashedBubble,
// Whether or not the UMA opt-in option should be shown.
bool offer_uma_optin_;
- // Whether or not a navigation has started on current tab.
- bool started_navigation_;
+ // Whether or not the first navigation was ignored. This is needed because the
+ // bubble shouldn't go away when the new tab page loads after a crash.
+ bool first_navigation_ignored_;
// Whether or not the user chose to restore previous session. It is used to
// collect bubble usage stats.
« no previous file with comments | « no previous file | chrome/browser/ui/views/session_crashed_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698