Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 2641813002: Add UMA for service worker navigation preload. (Closed)
Patch Set: patch for landing Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_url_request_job.h ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_url_request_job.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc
index 77a82de84346149dd8e02194c33410b7140a8db7..62325d45afcad222a5e754272585a8669ae67a78 100644
--- a/content/browser/service_worker/service_worker_url_request_job.cc
+++ b/content/browser/service_worker/service_worker_url_request_job.cc
@@ -555,9 +555,9 @@ void ServiceWorkerURLRequestJob::DidPrepareFetchEvent(
}
if (version->should_exclude_from_uma())
return;
- ServiceWorkerMetrics::RecordActivatedWorkerPreparationTimeForMainFrame(
+ ServiceWorkerMetrics::RecordActivatedWorkerPreparationForMainFrame(
worker_ready_time_ - request()->creation_time(), initial_worker_status_,
- version->embedded_worker()->start_situation());
+ version->embedded_worker()->start_situation(), did_navigation_preload_);
}
void ServiceWorkerURLRequestJob::DidDispatchFetchEvent(
@@ -879,7 +879,8 @@ void ServiceWorkerURLRequestJob::RequestBodyFileSizesResolved(bool success) {
base::Bind(&ServiceWorkerURLRequestJob::DidDispatchFetchEvent,
weak_factory_.GetWeakPtr())));
worker_start_time_ = base::TimeTicks::Now();
- fetch_dispatcher_->MaybeStartNavigationPreload(request());
+ did_navigation_preload_ =
+ fetch_dispatcher_->MaybeStartNavigationPreload(request());
fetch_dispatcher_->Run();
}
« no previous file with comments | « content/browser/service_worker/service_worker_url_request_job.h ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698