Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.cc

Issue 2641813002: Add UMA for service worker navigation preload. (Closed)
Patch Set: patch for landing Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_fetch_dispatcher.cc
diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.cc b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
index 7416f176854d7e230a3907619b153a47d9e4612d..ded2b794e4ed0cad9bae7954a4bc69530098b243 100644
--- a/content/browser/service_worker/service_worker_fetch_dispatcher.cc
+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
@@ -383,23 +383,23 @@ void ServiceWorkerFetchDispatcher::Complete(
fetch_callback.Run(status, fetch_result, response, version);
}
-void ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(
+bool ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(
net::URLRequest* original_request) {
if (resource_type_ != RESOURCE_TYPE_MAIN_FRAME &&
resource_type_ != RESOURCE_TYPE_SUB_FRAME) {
- return;
+ return false;
}
if (!version_->navigation_preload_state().enabled)
- return;
+ return false;
// TODO(horo): Currently NavigationPreload doesn't support request body.
if (!request_->blob_uuid.empty())
- return;
+ return false;
ServiceWorkerVersion::NavigationPreloadSupportStatus support_status =
version_->GetNavigationPreloadSupportStatus();
if (support_status !=
ServiceWorkerVersion::NavigationPreloadSupportStatus::SUPPORTED) {
- return;
+ return false;
}
ResourceRequestInfoImpl* original_info =
@@ -410,7 +410,7 @@ void ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(
} else {
DCHECK(requester_info->IsRenderer());
if (!requester_info->filter())
- return;
+ return false;
}
DCHECK(!url_loader_factory_);
@@ -474,6 +474,7 @@ void ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(
preload_handle_->url_loader = url_loader->CreateInterfacePtrAndBind();
url_loader_ = std::move(url_loader);
url_loader_client_ = std::move(url_loader_client);
+ return true;
}
ServiceWorkerMetrics::EventType ServiceWorkerFetchDispatcher::GetEventType()

Powered by Google App Engine
This is Rietveld 408576698