Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6338)

Unified Diff: chrome/common/extensions/docs/server2/instance_servlet.py

Issue 26418002: Docserver: Pull knowledge of host file systems into a single (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: correct similarity Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/instance_servlet.py
diff --git a/chrome/common/extensions/docs/server2/instance_servlet.py b/chrome/common/extensions/docs/server2/instance_servlet.py
index c39ffab4d272e68341718d6bcdaec44cfaf31dd4..3d4eca0c701e211021771a77944c7c1ff7c395f4 100644
--- a/chrome/common/extensions/docs/server2/instance_servlet.py
+++ b/chrome/common/extensions/docs/server2/instance_servlet.py
@@ -7,7 +7,7 @@ from branch_utility import BranchUtility
from compiled_file_system import CompiledFileSystem
from empty_dir_file_system import EmptyDirFileSystem
from github_file_system import GithubFileSystem
-from host_file_system_creator import HostFileSystemCreator
+from host_file_system_provider import HostFileSystemProvider
from third_party.json_schema_compiler.memoize import memoize
from render_servlet import RenderServlet
from object_store_creator import ObjectStoreCreator
@@ -35,20 +35,19 @@ class OfflineRenderServletDelegate(RenderServlet.Delegate):
def CreateServerInstance(self):
object_store_creator = ObjectStoreCreator(start_empty=False)
branch_utility = self._delegate.CreateBranchUtility(object_store_creator)
- host_file_system_creator = self._delegate.CreateHostFileSystemCreator(
- object_store_creator)
- host_file_system = host_file_system_creator.Create()
+ host_file_system_provider = self._delegate.CreateHostFileSystemProvider(
+ object_store_creator,
+ offline=True)
app_samples_file_system = self._delegate.CreateAppSamplesFileSystem(
object_store_creator)
compiled_host_fs_factory = CompiledFileSystem.Factory(
- host_file_system,
+ host_file_system_provider.GetTrunk(),
object_store_creator)
return ServerInstance(object_store_creator,
- host_file_system,
app_samples_file_system,
compiled_host_fs_factory,
branch_utility,
- host_file_system_creator)
+ host_file_system_provider)
class InstanceServlet(object):
'''Servlet for running on normal AppEngine instances.
@@ -61,8 +60,8 @@ class InstanceServlet(object):
def CreateBranchUtility(self, object_store_creator):
return BranchUtility.Create(object_store_creator)
- def CreateHostFileSystemCreator(self, object_store_creator):
- return HostFileSystemCreator(object_store_creator, offline=True)
+ def CreateHostFileSystemProvider(self, object_store_creator, offline=None):
+ return HostFileSystemProvider(object_store_creator, offline=offline)
def CreateAppSamplesFileSystem(self, object_store_creator):
# TODO(kalman): OfflineServerInstance wrapper for GithubFileSystem, but

Powered by Google App Engine
This is Rietveld 408576698