Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8644)

Unified Diff: chrome/common/extensions/docs/server2/app_yaml_helper.py

Issue 26418002: Docserver: Pull knowledge of host file systems into a single (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: correct similarity Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/app_yaml_helper.py
diff --git a/chrome/common/extensions/docs/server2/app_yaml_helper.py b/chrome/common/extensions/docs/server2/app_yaml_helper.py
index 63a0cc79158fa109f2e40120e3e1a9f6daddb901..cc3aebec1a3bd28f925ad5020fb012276ea885ac 100644
--- a/chrome/common/extensions/docs/server2/app_yaml_helper.py
+++ b/chrome/common/extensions/docs/server2/app_yaml_helper.py
@@ -18,16 +18,14 @@ class AppYamlHelper(object):
'''
def __init__(self,
app_yaml_path,
- file_system_at_head,
object_store_creator,
- host_file_system_creator):
+ host_file_system_provider):
self._app_yaml_path = app_yaml_path
- self._file_system_at_head = file_system_at_head
self._store = object_store_creator.Create(
AppYamlHelper,
- category=file_system_at_head.GetIdentity(),
+ category=host_file_system_provider.GetTrunk().GetIdentity(),
start_empty=False)
- self._host_file_system_creator = host_file_system_creator
+ self._host_file_system_provider = host_file_system_provider
@staticmethod
def ExtractVersion(app_yaml, key='version'):
@@ -74,7 +72,8 @@ class AppYamlHelper(object):
checked into the host file system.
'''
checked_in_app_version = AppYamlHelper.ExtractVersion(
- self._file_system_at_head.ReadSingle(self._app_yaml_path))
+ self._host_file_system_provider.GetTrunk().ReadSingle(
+ self._app_yaml_path))
if app_version == checked_in_app_version:
return True
if AppYamlHelper.IsGreater(app_version, checked_in_app_version):
@@ -109,7 +108,7 @@ class AppYamlHelper(object):
return AppYamlHelper.IsGreater(app_version_in_file_system, app_version)
found = None
- next_file_system = self._file_system_at_head
+ next_file_system = self._host_file_system_provider.GetTrunk()
while has_greater_app_version(next_file_system):
found = get_app_yaml_revision(next_file_system)
@@ -117,7 +116,7 @@ class AppYamlHelper(object):
if found == 0:
logging.warning('All revisions are greater than %s' % app_version)
return 0
- next_file_system = self._host_file_system_creator.Create(
+ next_file_system = self._host_file_system_provider.GetTrunk(
revision=found - 1)
if found is None:
« no previous file with comments | « chrome/common/extensions/docs/server2/app.yaml ('k') | chrome/common/extensions/docs/server2/app_yaml_helper_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698