Docserver: Pull knowledge of host file systems into a single

chrome/common/extensions/docs/server2/host_file_system_iterator_test.py

 #!/usr/bin/env python

[Jeffrey Yasskin, 2013/10/08 17:46:05]

This change is great because you changed the setup of the test and a bunch of
details in the production code, but the actual assertions didn't change at all,
so I know you didn't change any behavior.

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+from copy import deepcopy
 import unittest
 
-from host_file_system_creator import HostFileSystemCreator
-from host_file_system_creator_test import ConstructorForTest
+from host_file_system_provider import HostFileSystemProvider
 from host_file_system_iterator import HostFileSystemIterator
 from object_store_creator import ObjectStoreCreator
 from test_branch_utility import TestBranchUtility
+from test_data.canned_data import CANNED_API_FILE_SYSTEM_DATA
+from test_file_system import TestFileSystem
 
 
 def _GetIterationTracker(version):
   '''Adds the ChannelInfo object from each iteration to a list, and signals the
   loop to stop when |version| is reached.
   '''
   iterations = []
   def callback(file_system, channel_info):
     if channel_info.version == version:
       return False
     iterations.append(channel_info)
     return True
   return (iterations, callback)
 
 
 class HostFileSystemIteratorTest(unittest.TestCase):
 
   def setUp(self):
-    host_file_system_creator = HostFileSystemCreator(
+    def host_file_system_constructor(branch, **optargs):
+      return TestFileSystem(deepcopy(CANNED_API_FILE_SYSTEM_DATA[branch]))
+    host_file_system_provider = HostFileSystemProvider(
         ObjectStoreCreator.ForTest(),
-        constructor_for_test=ConstructorForTest)
+        constructor_for_test=host_file_system_constructor)
     self._branch_utility = TestBranchUtility.CreateWithCannedData()
     self._iterator = HostFileSystemIterator(
-        host_file_system_creator,
-        host_file_system_creator.Create('trunk'),
+        host_file_system_provider,
         self._branch_utility)
 
   def _GetStableChannelInfo(self,version):
     return self._branch_utility.GetStableChannelInfo(version)
 
   def _GetChannelInfo(self, channel_name):
     return self._branch_utility.GetChannelInfo(channel_name)
 
   def testAscending(self):
     # Start at |stable| version 5, and move up towards |trunk|.
@@ skipping 120 matching lines @@
                       self._GetStableChannelInfo(16),
                       self._GetStableChannelInfo(15),
                       self._GetStableChannelInfo(14),
                       self._GetStableChannelInfo(13),
                       self._GetStableChannelInfo(12),
                       self._GetStableChannelInfo(11)], iterations)
 
 
 if __name__ == '__main__':
   unittest.main()