Docserver: Pull knowledge of host file systems into a single

chrome/common/extensions/docs/server2/availability_finder_test.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import json
 
 import os
 import sys
 import unittest
 
 from availability_finder import AvailabilityFinder
 from api_schema_graph import LookupResult
 from branch_utility import BranchUtility
 from compiled_file_system import CompiledFileSystem
 from fake_url_fetcher import FakeUrlFetcher
 from host_file_system_iterator import HostFileSystemIterator
 from object_store_creator import ObjectStoreCreator
 from test_file_system import TestFileSystem
 from test_data.canned_data import (CANNED_API_FILE_SYSTEM_DATA, CANNED_BRANCHES)
 from test_data.object_level_availability.tabs import TABS_SCHEMA_BRANCHES
 
 
-class FakeHostFileSystemCreator(object):
+class FakeHostFileSystemProvider(object):
 
   def __init__(self, file_system_data):
     self._file_system_data = file_system_data
 
-  def Create(self, branch):
+  def GetTrunk(self):
+    return self.GetBranch('trunk')
+
+  def GetBranch(self, branch):
     return TestFileSystem(self._file_system_data[str(branch)])
 
 
 class AvailabilityFinderTest(unittest.TestCase):
 
   def setUp(self):
     self._branch_utility = BranchUtility(
         os.path.join('branch_utility', 'first.json'),
         os.path.join('branch_utility', 'second.json'),
         FakeUrlFetcher(os.path.join(sys.path[0], 'test_data')),
         ObjectStoreCreator.ForTest())
 
     def create_availability_finder(file_system_data):
-      fake_host_fs_creator = FakeHostFileSystemCreator(file_system_data)
-      fake_host_fs = fake_host_fs_creator.Create('trunk')
-      return AvailabilityFinder(HostFileSystemIterator(
-                                    fake_host_fs_creator,
-                                    fake_host_fs,
-                                    self._branch_utility),
+      fake_host_fs_creator = FakeHostFileSystemProvider(file_system_data)
+      return AvailabilityFinder(HostFileSystemIterator(fake_host_fs_creator,
+                                                       self._branch_utility),
                                 ObjectStoreCreator.ForTest(),
                                 self._branch_utility,
-                                fake_host_fs)
+                                fake_host_fs_creator.GetTrunk())
 
     self._avail_finder = create_availability_finder(CANNED_API_FILE_SYSTEM_DATA)
     self._node_avail_finder = create_availability_finder(TABS_SCHEMA_BRANCHES)
 
   def testGetApiAvailability(self):
     # Key: Using 'channel' (i.e. 'beta') to represent an availability listing
     # for an API in a _features.json file, and using |channel| (i.e. |dev|) to
     # represent the development channel, or phase of development, where an API's
     # availability is being checked.
 
@@ skipping 223 matching lines @@
     self.assertEqual(LookupResult(False, None),
                      availability_graph.Lookup('functions'))
     self.assertEqual(LookupResult(False, None),
                      availability_graph.Lookup('events', 'onActivated',
                                                'parameters', 'activeInfo',
                                                'tabId'))
 
 
 if __name__ == '__main__':
   unittest.main()