Issue 264173002: Revert 268265 "Add flac into root BUILD.gn"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264173002: Revert 268265 "Add flac into root BUILD.gn" (Closed)

Created:
6 years, 7 months ago by miu

Modified:
6 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 268265 "Add flac into root BUILD.gn" Caused compile errors on Android GN bot. > Add flac into root BUILD.gn > > All hail GN. oRZ > > BUG=none > > Review URL: https://codereview.chromium.org/263503003 TBR=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268270

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	trunk/src/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	trunk/src/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

miu

6 years, 7 months ago (2014-05-05 21:00:17 UTC) #3

Message was sent while issue was closed.

First build broken:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&n...