Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: components/sync/driver/glue/sync_backend_host_impl_unittest.cc

Issue 2641523004: [Sync] Make directory types registration explicit in ModelTypeRegistry (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/glue/sync_backend_host_impl_unittest.cc
diff --git a/components/sync/driver/glue/sync_backend_host_impl_unittest.cc b/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
index 21d8d42d380367937db990b2a8df5487792ae1dd..a96b4b2baa09ff3fcb713c048ac70e95063e0090 100644
--- a/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
+++ b/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
@@ -323,7 +323,6 @@ TEST_F(SyncEngineTest, FirstTimeSync) {
EXPECT_TRUE(fake_manager_->GetAndResetDownloadedTypes().HasAll(
Difference(enabled_types_, ControlTypes())));
EXPECT_EQ(enabled_types_, fake_manager_->InitialSyncEndedTypes());
- EXPECT_EQ(enabled_types_, fake_manager_->GetAndResetEnabledTypes());
EXPECT_TRUE(
fake_manager_->GetTypesWithEmptyProgressMarkerToken(enabled_types_)
.Empty());
@@ -353,7 +352,6 @@ TEST_F(SyncEngineTest, Restart) {
Intersection(fake_manager_->GetAndResetPurgedTypes(), enabled_types_)
.Empty());
EXPECT_EQ(enabled_types_, fake_manager_->InitialSyncEndedTypes());
- EXPECT_EQ(enabled_types_, fake_manager_->GetAndResetEnabledTypes());
EXPECT_TRUE(
fake_manager_->GetTypesWithEmptyProgressMarkerToken(enabled_types_)
.Empty());
@@ -389,7 +387,6 @@ TEST_F(SyncEngineTest, PartialTypes) {
.Empty());
EXPECT_EQ(partial_types, fake_manager_->GetAndResetDownloadedTypes());
EXPECT_EQ(enabled_types_, fake_manager_->InitialSyncEndedTypes());
- EXPECT_EQ(enabled_types_, fake_manager_->GetAndResetEnabledTypes());
EXPECT_TRUE(
fake_manager_->GetTypesWithEmptyProgressMarkerToken(enabled_types_)
.Empty());
@@ -424,7 +421,6 @@ TEST_F(SyncEngineTest, LostDB) {
Intersection(fake_manager_->GetAndResetPurgedTypes(), enabled_types_)
.Empty());
EXPECT_EQ(enabled_types_, fake_manager_->InitialSyncEndedTypes());
- EXPECT_EQ(enabled_types_, fake_manager_->GetAndResetEnabledTypes());
EXPECT_TRUE(
fake_manager_->GetTypesWithEmptyProgressMarkerToken(enabled_types_)
.Empty());
@@ -459,7 +455,6 @@ TEST_F(SyncEngineTest, DisableTypes) {
EXPECT_EQ(disabled_types,
Intersection(fake_manager_->GetAndResetPurgedTypes(), old_types));
EXPECT_EQ(enabled_types_, fake_manager_->InitialSyncEndedTypes());
- EXPECT_EQ(enabled_types_, fake_manager_->GetAndResetEnabledTypes());
EXPECT_TRUE(
fake_manager_->GetTypesWithEmptyProgressMarkerToken(enabled_types_)
.Empty());
@@ -495,7 +490,6 @@ TEST_F(SyncEngineTest, AddTypes) {
Intersection(fake_manager_->GetAndResetPurgedTypes(), enabled_types_)
.Empty());
EXPECT_EQ(enabled_types_, fake_manager_->InitialSyncEndedTypes());
- EXPECT_EQ(enabled_types_, fake_manager_->GetAndResetEnabledTypes());
EXPECT_TRUE(
fake_manager_->GetTypesWithEmptyProgressMarkerToken(enabled_types_)
.Empty());
@@ -534,7 +528,6 @@ TEST_F(SyncEngineTest, AddDisableTypes) {
EXPECT_EQ(disabled_types,
Intersection(fake_manager_->GetAndResetPurgedTypes(), old_types));
EXPECT_EQ(enabled_types_, fake_manager_->InitialSyncEndedTypes());
- EXPECT_EQ(enabled_types_, fake_manager_->GetAndResetEnabledTypes());
EXPECT_EQ(disabled_types,
fake_manager_->GetTypesWithEmptyProgressMarkerToken(old_types));
}
@@ -570,7 +563,6 @@ TEST_F(SyncEngineTest, NewlySupportedTypes) {
Intersection(fake_manager_->GetAndResetPurgedTypes(), enabled_types_)
.Empty());
EXPECT_EQ(enabled_types_, fake_manager_->InitialSyncEndedTypes());
- EXPECT_EQ(enabled_types_, fake_manager_->GetAndResetEnabledTypes());
EXPECT_TRUE(
fake_manager_->GetTypesWithEmptyProgressMarkerToken(enabled_types_)
.Empty());
@@ -612,7 +604,6 @@ TEST_F(SyncEngineTest, NewlySupportedTypesWithPartialTypes) {
Intersection(fake_manager_->GetAndResetPurgedTypes(), enabled_types_)
.Empty());
EXPECT_EQ(enabled_types_, fake_manager_->InitialSyncEndedTypes());
- EXPECT_EQ(enabled_types_, fake_manager_->GetAndResetEnabledTypes());
EXPECT_TRUE(
fake_manager_->GetTypesWithEmptyProgressMarkerToken(enabled_types_)
.Empty());
« no previous file with comments | « components/sync/driver/glue/sync_backend_host_impl.cc ('k') | components/sync/driver/model_association_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698