Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/sync/driver/proxy_data_type_controller.h

Issue 2641523004: [Sync] Make directory types registration explicit in ModelTypeRegistry (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/sync/driver/model_type_controller_unittest.cc ('K') | « components/sync/driver/model_type_controller_unittest.cc ('k') | components/sync/driver/proxy_data_type_controller.cc » ('j') | components/sync/engine/sync_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/driver/proxy_data_type_controller.h
diff --git a/components/sync/driver/proxy_data_type_controller.h b/components/sync/driver/proxy_data_type_controller.h
index 635e6563f113d48999b3848f6f7c1afe6af536a9..229a2951b67e4b53b6509f5e3c9bf8f52c39559d 100644
--- a/components/sync/driver/proxy_data_type_controller.h
+++ b/components/sync/driver/proxy_data_type_controller.h
@@ -24,6 +24,7 @@ class ProxyDataTypeController : public DataTypeController {
// DataTypeController interface.
bool ShouldLoadModelBeforeConfigure() const override;
void LoadModels(const ModelLoadCallback& model_load_callback) override;
+ void BeforeLoadModels(ModelTypeConfigurer* configurer) override;
maxbogue 2017/01/19 19:19:55 Above LoadModels, here and in cc
pavely 2017/01/19 20:27:39 Done.
void RegisterWithBackend(base::Callback<void(bool)> set_downloaded,
ModelTypeConfigurer* configurer) override;
void StartAssociating(const StartCallback& start_callback) override;
« components/sync/driver/model_type_controller_unittest.cc ('K') | « components/sync/driver/model_type_controller_unittest.cc ('k') | components/sync/driver/proxy_data_type_controller.cc » ('j') | components/sync/engine/sync_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698