Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: components/sync/tools/sync_client.cc

Issue 2641523004: [Sync] Make directory types registration explicit in ModelTypeRegistry (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/tools/sync_client.cc
diff --git a/components/sync/tools/sync_client.cc b/components/sync/tools/sync_client.cc
index 69954bca77b5c59e113ce9f4b7da26a9cf52c4b1..5ff4517f04a2afc45417ac5dea6b43c741313fef 100644
--- a/components/sync/tools/sync_client.cc
+++ b/components/sync/tools/sync_client.cc
@@ -378,10 +378,6 @@ int SyncClientMain(int argc, char* argv[]) {
model_types.Put(FAVICON_IMAGES);
model_types.Put(FAVICON_TRACKING);
- ModelSafeRoutingInfo routing_info;
- for (ModelTypeSet::Iterator it = model_types.First(); it.Good(); it.Inc()) {
- routing_info[it.Get()] = GROUP_PASSIVE;
- }
scoped_refptr<PassiveModelWorker> passive_model_safe_worker =
new PassiveModelWorker();
std::vector<scoped_refptr<ModelSafeWorker>> workers;
@@ -442,7 +438,13 @@ int SyncClientMain(int argc, char* argv[]) {
invalidator->RegisterHandler(shim.get());
CHECK(invalidator->UpdateRegisteredIds(
shim.get(), ModelTypeSetToObjectIdSet(model_types)));
- sync_manager->StartSyncingNormally(routing_info, base::Time());
+ std::unique_ptr<ModelTypeConnector> model_type_connector =
+ sync_manager->GetModelTypeConnectorProxy();
+ for (ModelTypeSet::Iterator it = model_types.First(); it.Good(); it.Inc()) {
+ model_type_connector->RegisterDirectoryType(it.Get(), GROUP_PASSIVE);
maxbogue 2017/01/18 01:24:11 Same comment here as SBHC.
pavely 2017/01/18 20:18:07 Done.
+ }
+
+ sync_manager->StartSyncingNormally(base::Time());
base::RunLoop().Run();

Powered by Google App Engine
This is Rietveld 408576698