Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2641523002: Fix some crashes in dartk. (Closed)

Created:
3 years, 11 months ago by asgerf
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some crashes in dartk. Dartk should no longer crash in these cases: - main method is provided through an export - main method is missing - initializing formal parameter is unresolved - the loadLibrary function is torn off BUG= R=kmillikin@google.com, vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/d01bd88152b2d30d6a06d1379e41e1280d094dab Committed: https://github.com/dart-lang/sdk/commit/979072821d1113248e285f7926663eb00d8a8206 Committed: https://github.com/dart-lang/sdk/commit/d4dfb3088e3da9992d944123fbfb217d0e6cbfff

Patch Set 1 #

Patch Set 2 : Revert + Unrevert #

Patch Set 3 : Move status line to the shared section #

Patch Set 4 : Revert+Unrevert again #

Patch Set 5 : Mark main as static, update status files again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -30 lines) Patch
M pkg/kernel/lib/analyzer/ast_from_analyzer.dart View 1 4 chunks +28 lines, -7 lines 0 comments Download
M pkg/kernel/lib/analyzer/loader.dart View 1 2 3 4 4 chunks +37 lines, -6 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 2 3 4 5 chunks +1 line, -10 lines 0 comments Download
M tests/language/language_kernel.status View 1 2 3 6 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
asgerf
3 years, 11 months ago (2017-01-17 19:20:16 UTC) #3
Kevin Millikin (Google)
LGTM.
3 years, 11 months ago (2017-01-18 09:11:19 UTC) #4
Vyacheslav Egorov (Google)
lgtm
3 years, 11 months ago (2017-01-18 09:30:05 UTC) #5
asgerf
Committed patchset #1 (id:1) manually as d01bd88152b2d30d6a06d1379e41e1280d094dab (presubmit successful).
3 years, 11 months ago (2017-01-18 09:39:17 UTC) #7
asgerf
Committed patchset #3 (id:40001) manually as 979072821d1113248e285f7926663eb00d8a8206 (presubmit successful).
3 years, 11 months ago (2017-01-18 15:44:52 UTC) #9
asgerf
3 years, 11 months ago (2017-01-19 11:12:43 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
d4dfb3088e3da9992d944123fbfb217d0e6cbfff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698