Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2641433002: Support tests using VMOptions also with kernel (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : More fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -7 lines) Patch
M tests/language/language.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_kernel.status View 1 2 3 chunks +16 lines, -3 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 2 3 chunks +29 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
3 years, 11 months ago (2017-01-17 15:25:37 UTC) #2
Bill Hesse
lgtm
3 years, 11 months ago (2017-01-17 15:30:01 UTC) #3
kustermann
3 years, 11 months ago (2017-01-18 17:48:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f95701bf6119f41dfcda921268ff07836bd86898 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698