Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

Issue 264143002: Revert 268250 "Pepper: Move manifest logic to components/nacl." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
===================================================================
--- trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc (revision 268257)
+++ trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc (working copy)
@@ -39,7 +39,7 @@
ld_subprocess_active_(false),
done_(false),
compile_time_(0),
- manifest_id_(0),
+ manifest_(NULL),
obj_files_(NULL),
nexe_file_(NULL),
coordinator_error_info_(NULL),
@@ -53,7 +53,7 @@
void PnaclTranslateThread::RunTranslate(
const pp::CompletionCallback& finish_callback,
- int32_t manifest_id,
+ const Manifest* manifest,
const std::vector<TempFile*>* obj_files,
TempFile* nexe_file,
nacl::DescWrapper* invalid_desc_wrapper,
@@ -63,7 +63,7 @@
PnaclCoordinator* coordinator,
Plugin* plugin) {
PLUGIN_PRINTF(("PnaclStreamingTranslateThread::RunTranslate)\n"));
- manifest_id_ = manifest_id;
+ manifest_ = manifest;
obj_files_ = obj_files;
nexe_file_ = nexe_file;
invalid_desc_wrapper_ = invalid_desc_wrapper;
@@ -129,7 +129,7 @@
NaClSubprocess* PnaclTranslateThread::StartSubprocess(
const nacl::string& url_for_nexe,
- int32_t manifest_id,
+ const Manifest* manifest,
ErrorInfo* error_info) {
PLUGIN_PRINTF(("PnaclTranslateThread::StartSubprocess (url_for_nexe=%s)\n",
url_for_nexe.c_str()));
@@ -140,8 +140,8 @@
// string gets silently dropped by GURL.
nacl::string full_url = resources_->GetFullUrl(
url_for_nexe, plugin_->nacl_interface()->GetSandboxArch());
- nacl::scoped_ptr<NaClSubprocess> subprocess(plugin_->LoadHelperNaClModule(
- full_url, wrapper, manifest_id, error_info));
+ nacl::scoped_ptr<NaClSubprocess> subprocess(
+ plugin_->LoadHelperNaClModule(full_url, wrapper, manifest, error_info));
if (subprocess.get() == NULL) {
PLUGIN_PRINTF((
"PnaclTranslateThread::StartSubprocess: subprocess creation failed\n"));
@@ -173,7 +173,7 @@
nacl::MutexLocker ml(&subprocess_mu_);
int64_t llc_start_time = NaClGetTimeOfDayMicroseconds();
llc_subprocess_.reset(
- StartSubprocess(resources_->GetLlcUrl(), manifest_id_, &error_info));
+ StartSubprocess(resources_->GetLlcUrl(), manifest_, &error_info));
if (llc_subprocess_ == NULL) {
TranslateFailed(PP_NACL_ERROR_PNACL_LLC_SETUP,
"Compile process could not be created: " +
@@ -350,7 +350,7 @@
nacl::MutexLocker ml(&subprocess_mu_);
int64_t ld_start_time = NaClGetTimeOfDayMicroseconds();
ld_subprocess_.reset(
- StartSubprocess(resources_->GetLdUrl(), manifest_id_, &error_info));
+ StartSubprocess(resources_->GetLdUrl(), manifest_, &error_info));
if (ld_subprocess_ == NULL) {
TranslateFailed(PP_NACL_ERROR_PNACL_LD_SETUP,
"Link process could not be created: " +

Powered by Google App Engine
This is Rietveld 408576698