chrome/browser/ui/views/frame/browser_view.cc - Issue 2641403002: [refactor] - Move IsFocusedElementEditable() and ClearFocusedElement() from RenderViewHost to WebCo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2641403002: [refactor] - Move IsFocusedElementEditable() and ClearFocusedElement() from RenderViewHost to WebCo… (Closed)

Patch Set: Reformat WebContentsImpl Header File Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 73ece4834dedcb423448918b5f124b873331e537..4258065f9b6f7b24370af5b7fcc163294eef9f3d 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1212,8 +1212,7 @@ ShowTranslateBubbleResult BrowserView::ShowTranslateBubble(

bool is_user_gesture) {

if (contents_web_view_->HasFocus() &&

!GetLocationBarView()->IsMouseHovered()) {

- content::RenderViewHost* rvh = web_contents->GetRenderViewHost();

- if (rvh->IsFocusedElementEditable())

+ if (web_contents->IsFocusedElementEditable())

sky 2017/01/24 22:08:06 Now that there is no temporary combine the if stat

EhsanK 2017/01/25 01:05:37 Done. Thanks!

return ShowTranslateBubbleResult::EDITABLE_FIELD_IS_ACTIVE;

}