Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26414004: Move core/scripts to build/scripts so that platform can use them. (Closed)

Created:
7 years, 2 months ago by Stephen Chennney
Modified:
7 years, 2 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Move core/scripts to build/scripts so that platform can use them. R=abarth@chromium.org, eseidel@chromium.org BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159266

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5975 lines) Patch
M Source/bindings/derived_sources.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
A + Source/build/scripts/Hasher.pm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/InFilesCompiler.pm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/InFilesParser.pm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/StaticString.pm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/action_derivedsourcesallinone.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/action_makenames.py View 1 chunk +1 line, -1 line 0 comments Download
A + Source/build/scripts/action_useragentstylesheets.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/check_objc_rename.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/hasher.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/in_file.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/in_file_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/in_generator.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/license.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/make-hash-tools.pl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/make_css_property_names.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/make_css_value_keywords.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/make_event_factory.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/make_internal_runtime_flags.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/make_names.pl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/build/scripts/make_names.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/make_runtime_features.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/make_style_builder.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/make_style_shorthands.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/make_token_matcher.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/make_token_matcher_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/name_macros.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/name_utilities.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/preprocessor.pm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/rule_bison.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/template_expander.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/InternalRuntimeFlags.idl.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/MakeNames.cpp.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/MakeNames.h.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/RuntimeEnabledFeatures.h.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/StyleBuilder.cpp.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/StyleBuilderFunctions.h.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/StylePropertyShorthand.cpp.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/StylePropertyShorthand.h.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/templates/macros.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/build/scripts/xxd.pl View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/ConvertFileToHeaderWithCharacterArray.gypi View 1 chunk +2 lines, -2 lines 1 comment Download
M Source/core/core.gyp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/core_derived_sources.gyp View 45 chunks +72 lines, -72 lines 0 comments Download
D Source/core/scripts/Hasher.pm View 1 chunk +0 lines, -93 lines 0 comments Download
D Source/core/scripts/InFilesCompiler.pm View 1 chunk +0 lines, -182 lines 0 comments Download
D Source/core/scripts/InFilesParser.pm View 1 chunk +0 lines, -154 lines 0 comments Download
D Source/core/scripts/StaticString.pm View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/core/scripts/action_derivedsourcesallinone.py View 1 chunk +0 lines, -225 lines 0 comments Download
D Source/core/scripts/action_makenames.py View 1 chunk +0 lines, -181 lines 0 comments Download
D Source/core/scripts/action_useragentstylesheets.py View 1 chunk +0 lines, -124 lines 0 comments Download
D Source/core/scripts/check_objc_rename.sh View 1 chunk +0 lines, -79 lines 0 comments Download
D Source/core/scripts/hasher.py View 1 chunk +0 lines, -83 lines 0 comments Download
D Source/core/scripts/in_file.py View 1 chunk +0 lines, -160 lines 0 comments Download
D Source/core/scripts/in_file_unittest.py View 1 chunk +0 lines, -77 lines 0 comments Download
D Source/core/scripts/in_generator.py View 1 chunk +0 lines, -119 lines 0 comments Download
D Source/core/scripts/license.py View 1 chunk +0 lines, -62 lines 0 comments Download
D Source/core/scripts/make-hash-tools.pl View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/core/scripts/make_css_property_names.py View 1 chunk +0 lines, -257 lines 0 comments Download
D Source/core/scripts/make_css_value_keywords.py View 1 chunk +0 lines, -177 lines 0 comments Download
D Source/core/scripts/make_event_factory.py View 1 chunk +0 lines, -100 lines 0 comments Download
D Source/core/scripts/make_internal_runtime_flags.py View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/core/scripts/make_names.pl View 1 chunk +0 lines, -1284 lines 0 comments Download
D Source/core/scripts/make_names.py View 1 chunk +0 lines, -65 lines 0 comments Download
D Source/core/scripts/make_runtime_features.py View 1 chunk +0 lines, -92 lines 0 comments Download
D Source/core/scripts/make_style_builder.py View 1 chunk +0 lines, -128 lines 0 comments Download
D Source/core/scripts/make_style_shorthands.py View 1 chunk +0 lines, -96 lines 0 comments Download
D Source/core/scripts/make_token_matcher.py View 1 chunk +0 lines, -231 lines 0 comments Download
D Source/core/scripts/make_token_matcher_unittest.py View 1 chunk +0 lines, -243 lines 0 comments Download
D Source/core/scripts/name_macros.py View 1 chunk +0 lines, -175 lines 0 comments Download
D Source/core/scripts/name_utilities.py View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/core/scripts/preprocessor.pm View 1 chunk +0 lines, -89 lines 0 comments Download
D Source/core/scripts/rule_bison.py View 1 chunk +0 lines, -105 lines 0 comments Download
D Source/core/scripts/template_expander.py View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/core/scripts/templates/InternalRuntimeFlags.h.tmpl View 1 chunk +0 lines, -39 lines 0 comments Download
D Source/core/scripts/templates/InternalRuntimeFlags.idl.tmpl View 1 chunk +0 lines, -14 lines 0 comments Download
D Source/core/scripts/templates/MakeNames.cpp.tmpl View 1 chunk +0 lines, -36 lines 0 comments Download
D Source/core/scripts/templates/MakeNames.h.tmpl View 1 chunk +0 lines, -25 lines 0 comments Download
D Source/core/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl View 1 chunk +0 lines, -24 lines 0 comments Download
D Source/core/scripts/templates/RuntimeEnabledFeatures.h.tmpl View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/core/scripts/templates/StyleBuilder.cpp.tmpl View 1 chunk +0 lines, -85 lines 0 comments Download
D Source/core/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +0 lines, -519 lines 0 comments Download
D Source/core/scripts/templates/StyleBuilderFunctions.h.tmpl View 1 chunk +0 lines, -29 lines 0 comments Download
D Source/core/scripts/templates/StylePropertyShorthand.cpp.tmpl View 1 chunk +0 lines, -90 lines 0 comments Download
D Source/core/scripts/templates/StylePropertyShorthand.h.tmpl View 1 chunk +0 lines, -88 lines 0 comments Download
D Source/core/scripts/templates/macros.tmpl View 1 chunk +0 lines, -48 lines 0 comments Download
D Source/core/scripts/xxd.pl View 1 chunk +0 lines, -45 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/style/checker.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Stephen Chennney
7 years, 2 months ago (2013-10-09 17:14:30 UTC) #1
Stephen Chennney
On 2013/10/09 17:14:30, Stephen Chenney wrote: One file wasn't moved from core/scripts to build/scripts because ...
7 years, 2 months ago (2013-10-09 17:15:31 UTC) #2
abarth-chromium
LGTM! Thanks for doing this. https://codereview.chromium.org/26414004/diff/1/Source/core/ConvertFileToHeaderWithCharacterArray.gypi File Source/core/ConvertFileToHeaderWithCharacterArray.gypi (right): https://codereview.chromium.org/26414004/diff/1/Source/core/ConvertFileToHeaderWithCharacterArray.gypi#newcode44 Source/core/ConvertFileToHeaderWithCharacterArray.gypi:44: 'action_name': 'ConvertFileToHeaderWithCharacterArray', We should ...
7 years, 2 months ago (2013-10-09 17:27:32 UTC) #3
Stephen Chennney
7 years, 2 months ago (2013-10-09 23:02:04 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r159266 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698