Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2641353002: Make full_emitter parts into libraries (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -18 lines) Patch
M pkg/compiler/lib/src/js_emitter/full_emitter/class_builder.dart View 1 chunk +11 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +25 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart View 1 chunk +15 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 5 chunks +12 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 1 chunk +13 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-20 15:18:23 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 11 months ago (2017-01-20 17:01:33 UTC) #3
Johnni Winther
3 years, 11 months ago (2017-01-23 10:11:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f39cc6148959d5f96c40e2e08f244f7f90807fe2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698