Make PhaseOutput emit a new AssetNode whenever it changes outputs.

pkg/barback/test/package_graph/group_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library barback.test.package_graph.group_test;
 
+import 'dart:async';
+
 import 'package:barback/barback.dart';
 import 'package:scheduled_test/scheduled_test.dart';
 
 import '../utils.dart';
 
 main() {
   initConfig();
   test("runs transforms in a group", () {
     initGraph(["app|foo.a"], {"app": [
       [new TransformerGroup([
@@ skipping 289 matching lines @@
     test("doesn't detect a collision for an input that's modified in-place by "
         "a group", () {
       initGraph(["app|foo.a"], {"app": [[
         new TransformerGroup([[new RewriteTransformer("a", "a")]]),
         new RewriteTransformer("x", "y")
       ]]});
       updateSources(["app|foo.a"]);
       expectAsset("app|foo.a", "foo.a");
       buildShouldSucceed();
     });
+
+    test("doesn't pass-through an asset that ceases to be forwarded due to a "
+        "resolved collision", () {
+      initGraph({
+        "app|foo.a": "foo.a",
+        "app|foo.x": "foo.x"
+      }, {"app": [
+        [new TransformerGroup([[
+          new CheckContentAndRenameTransformer(
+              "a", "new foo.a", "z", "modified foo.a"),
+          new RewriteTransformer('x', 'a')
+        ]])]
+      ]});
+
+      updateSources(["app|foo.a", "app|foo.x"]);
+      expectAsset("app|foo.a", "foo.a");
+      expectNoAsset("app|foo.z");
+      buildShouldFail([isAssetCollisionException("app|foo.a")]);
+
+      modifyAsset('app|foo.a', 'new foo.a');
+      updateSources(["app|foo.a"]);
+      expectAsset("app|foo.a", "foo.x.a");
+      expectAsset("app|foo.z", "modified foo.a");
+      buildShouldSucceed();
+    });
   });
 
   test("runs transforms in an added group", () {
     var rewrite = new RewriteTransformer("a", "z");
     initGraph(["app|foo.a"], {"app": [[rewrite]]});
 
     updateSources(["app|foo.a"]);
     expectAsset("app|foo.z", "foo.z");
     buildShouldSucceed();
 
@@ skipping 66 matching lines @@
       new TransformerGroup([
         [new RewriteTransformer("a", "b")],
         [new RewriteTransformer("b", "c")]
       ]),
       new RewriteTransformer("x", "c")
     ]]});
     updateSources(["app|foo.a", "app|foo.x"]);
     buildShouldFail([isAssetCollisionException("app|foo.c")]);
   });
 }
+
+/// A transformer that checks the extension and content of an asset, then
+/// produces a new asset with a new extension and new content.
+class CheckContentAndRenameTransformer extends MockTransformer {

[Bob Nystrom, 2013/10/08 21:07:36]

Move this to its own file in test/transformer.

[nweiz, 2013/10/08 22:20:12]

Done. I didn't do that originally because it seemed so specific to the test that
uses it here, but sure.

+  final String oldExtension;
+  final String oldContent;
+  final String newExtension;
+  final String newContent;
+
+  CheckContentAndRenameTransformer(this.oldExtension, this.oldContent,
+      this.newExtension, this.newContent);
+
+  Future<bool> doIsPrimary(Asset asset) {
+    if (asset.id.extension != '.$oldExtension') return new Future.value(false);
+    return asset.readAsString().then((value) => value == oldContent);
+  }
+
+  Future doApply(Transform transform) {
+    return getPrimary(transform).then((input) {
+      transform.addOutput(new Asset.fromString(
+          input.id.changeExtension('.$newExtension'), newContent));
+    });
+  }
+}