Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/browser/media/webrtc/webrtc_browsertest_base.cc

Issue 2641263003: Performance measures of old and new RTCPeerConnection.getStats added. (Closed)
Patch Set: Avoiding win uninitialized variable warning Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/webrtc_browsertest_base.cc
diff --git a/chrome/browser/media/webrtc/webrtc_browsertest_base.cc b/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
index d232889106d41036fd8bd191f11b1aa6336317b1..5ddf0ad6b5a608d09878c6f382f165c7de436d4c 100644
--- a/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
+++ b/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
@@ -6,10 +6,13 @@
#include <stddef.h>
+#include <limits>
+
#include "base/json/json_reader.h"
#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/macros.h"
+#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/values.h"
@@ -497,6 +500,17 @@ std::vector<std::string> WebRtcTestBase::VerifyStatsGeneratedPromise(
return JsonArrayToVectorOfStrings(result.substr(3));
}
+double WebRtcTestBase::MeasureGetStatsCallbackPerformance(
+ content::WebContents* tab) const {
+ std::string result = ExecuteJavascript(
+ "measureGetStatsCallbackPerformance()", tab);
+ EXPECT_TRUE(base::StartsWith(result, "ok-", base::CompareCase::SENSITIVE));
+ double ms;
+ if (!base::StringToDouble(result.substr(3), &ms))
+ return std::numeric_limits<double>::infinity();
+ return ms;
+}
+
scoped_refptr<content::TestStatsReportDictionary>
WebRtcTestBase::GetStatsReportDictionary(content::WebContents* tab) const {
std::string result = ExecuteJavascript("getStatsReportDictionary()", tab);
@@ -512,6 +526,16 @@ WebRtcTestBase::GetStatsReportDictionary(content::WebContents* tab) const {
std::unique_ptr<base::DictionaryValue>(dictionary)));
}
+double WebRtcTestBase::MeasureGetStatsPerformance(
+ content::WebContents* tab) const {
+ std::string result = ExecuteJavascript("measureGetStatsPerformance()", tab);
+ EXPECT_TRUE(base::StartsWith(result, "ok-", base::CompareCase::SENSITIVE));
+ double ms;
+ if (!base::StringToDouble(result.substr(3), &ms))
+ return std::numeric_limits<double>::infinity();
+ return ms;
+}
+
std::vector<std::string> WebRtcTestBase::GetWhitelistedStatsTypes(
content::WebContents* tab) const {
return JsonArrayToVectorOfStrings(

Powered by Google App Engine
This is Rietveld 408576698