Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_units.h

Issue 2641253002: Rewrite LayoutNG margin collapsing/floats unit tests (Closed)
Patch Set: git rebase-update + more tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_units.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_units.h b/third_party/WebKit/Source/core/layout/ng/ng_units.h
index d5b98d198204e8bfbd054864bc8c07f48171d314..f2a5972ad045506ea1c6e327c37fc7f977d8f66c 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_units.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_units.h
@@ -44,13 +44,6 @@ struct NGLogicalSize {
bool IsEmpty() const {
return inline_size == LayoutUnit() || block_size == LayoutUnit();
}
-
- private:
- friend class NGBlockLayoutAlgorithmTest;
- // Used in tests.
- NGLogicalSize(int inline_size, int block_size)
- : inline_size(LayoutUnit(inline_size)),
- block_size(LayoutUnit(block_size)) {}
};
inline std::ostream& operator<<(std::ostream& stream,
@@ -96,13 +89,6 @@ struct NGLogicalOffset {
bool operator<=(const NGLogicalOffset& other) const;
String ToString() const;
-
- private:
- friend class NGBlockLayoutAlgorithmTest;
- // Used in tests.
- NGLogicalOffset(int inline_offset, int block_offset)
- : inline_offset(LayoutUnit(inline_offset)),
- block_offset(LayoutUnit(block_offset)) {}
};
CORE_EXPORT inline std::ostream& operator<<(std::ostream& os,
@@ -130,7 +116,7 @@ struct NGPhysicalOffset {
}
};
-struct NGPhysicalSize {
+struct CORE_EXPORT NGPhysicalSize {
NGPhysicalSize() {}
NGPhysicalSize(LayoutUnit width, LayoutUnit height)
: width(width), height(height) {}

Powered by Google App Engine
This is Rietveld 408576698