Removed usage of std::map and std::vector from kernel code. Issue #28064.

runtime/vm/growable_array.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Defines growable array classes, that differ where they are allocated:
 // - GrowableArray: allocated on stack.
 // - ZoneGrowableArray: allocated in the zone.
 // - MallocGrowableArray: allocates using malloc/realloc; free is only called
 //   at destruction.
 
 #ifndef RUNTIME_VM_GROWABLE_ARRAY_H_
@@ skipping 20 matching lines @@
     }
   }
 
   ~BaseGrowableArray() { allocator_->template Free<T>(data_, capacity_); }
 
   intptr_t length() const { return length_; }
   T* data() const { return data_; }
   bool is_empty() const { return length_ == 0; }
 
   void TruncateTo(intptr_t length) {
-    ASSERT(length_ >= length);
+    ASSERT(length >= 0);
+    ASSERT(static_cast<uintptr_t>(length_) >= static_cast<uintptr_t>(length));

[bkonyi, 2017/01/19 20:48:46]

The compiler was complaining that doing length_ >= length could lead to bad
results in the case of overflows. Checking if length is positive before casting
to uintptr_t should be sufficient.

[zra, 2017/01/19 21:06:25]

I think it's not worried about overflow here, but rather at the call-sites of
TruncateTo in kernel_binary.cc. I think we might need to change instances of int
-> intptr_t in that file.

[bkonyi, 2017/01/20 23:56:28]

See comment in new patch in kernel_binary.

     length_ = length;
   }
 
   void Add(const T& value) {
     Resize(length() + 1);
     Last() = value;
   }
 
   T& RemoveLast() {
     ASSERT(length_ > 0);
@@ skipping 222 matching lines @@
 class MallocGrowableArray : public BaseGrowableArray<T, EmptyBase, Malloc> {
  public:
   explicit MallocGrowableArray(intptr_t initial_capacity)
       : BaseGrowableArray<T, EmptyBase, Malloc>(initial_capacity, NULL) {}
   MallocGrowableArray() : BaseGrowableArray<T, EmptyBase, Malloc>(NULL) {}
 };
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_GROWABLE_ARRAY_H_