Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: chrome/browser/extensions/activity_log/activity_actions.cc

Issue 264123004: Modify rappor parameters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/activity_log/activity_actions.h" 5 #include "chrome/browser/extensions/activity_log/activity_actions.h"
6 6
7 #include <algorithm> // for std::find. 7 #include <algorithm> // for std::find.
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 27 matching lines...) Expand all
38 38
39 namespace keys = ad_injection_constants::keys; 39 namespace keys = ad_injection_constants::keys;
40 40
41 // The list of APIs for which we upload the URL to RAPPOR. 41 // The list of APIs for which we upload the URL to RAPPOR.
42 const char* kApisForRapporMetric[] = { 42 const char* kApisForRapporMetric[] = {
43 "HTMLIFrameElement.src", 43 "HTMLIFrameElement.src",
44 "HTMLEmbedElement.src", 44 "HTMLEmbedElement.src",
45 "HTMLAnchorElement.href", 45 "HTMLAnchorElement.href",
46 }; 46 };
47 47
48 // The "Extensions.PossibleAdInjection2" metric uses different Rappor
49 // parameters than the original metric.
48 const char* kExtensionAdInjectionRapporMetricName = 50 const char* kExtensionAdInjectionRapporMetricName =
49 "Extensions.PossibleAdInjection"; 51 "Extensions.PossibleAdInjection2";
50 52
51 // The elements for which we check the 'src' attribute to look for ads. 53 // The elements for which we check the 'src' attribute to look for ads.
52 const char* kSrcElements[] = { 54 const char* kSrcElements[] = {
53 "HTMLIFrameElement", 55 "HTMLIFrameElement",
54 "HTMLEmbedElement" 56 "HTMLEmbedElement"
55 }; 57 };
56 58
57 // The elements for which we check the 'href' attribute to look for ads. 59 // The elements for which we check the 'href' attribute to look for ads.
58 const char* kHrefElements[] = { 60 const char* kHrefElements[] = {
59 "HTMLAnchorElement", 61 "HTMLAnchorElement",
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
532 std::string rhs_other = ActivityLogPolicy::Util::Serialize(rhs->other()); 534 std::string rhs_other = ActivityLogPolicy::Util::Serialize(rhs->other());
533 if (lhs_other != rhs_other) 535 if (lhs_other != rhs_other)
534 return lhs_other < rhs_other; 536 return lhs_other < rhs_other;
535 } 537 }
536 538
537 // All fields compare as equal if this point is reached. 539 // All fields compare as equal if this point is reached.
538 return false; 540 return false;
539 } 541 }
540 542
541 } // namespace extensions 543 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/prefs/pref_metrics_service.cc » ('j') | components/rappor/rappor_metric.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698