chrome/browser/notifications/message_center_notifications_unittest_win.cc - Issue 264123002: Google Now Message Center Stats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notifications_unittest_win.cc

Issue 264123002: Google Now Message Center Stats (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Refactor Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/google_now_notification_stats_collector.cc ('K') | « chrome/browser/notifications/message_center_notification_manager.cc ('k') | chrome/browser/notifications/message_center_stats_collector.h » ('j') | ui/message_center/message_center_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/message_center_notifications_unittest_win.cc

diff --git a/chrome/browser/notifications/message_center_notifications_unittest_win.cc b/chrome/browser/notifications/message_center_notifications_unittest_win.cc

index 86b19ed6864030eea14a73c6dc0cc346cca565ee..b447deea46755899069d6e902bf786c57bcc69a9 100644

--- a/chrome/browser/notifications/message_center_notifications_unittest_win.cc

+++ b/chrome/browser/notifications/message_center_notifications_unittest_win.cc

@@ -105,7 +105,8 @@ TEST_F(MessageCenterNotificationManagerTest, SetupNotificationManager) {

TEST_F(MessageCenterNotificationManagerTest, FirstRunShown) {

TestingProfile profile;

notification_manager()->Add(GetANotification("test"), &profile);

- message_center()->DisplayedNotification("test");

+ message_center()->DisplayedNotification(

+ "test", message_center::MESSAGE_CENTER);

message_center()->MarkSinglePopupAsShown("test", false);

run_loop()->Run();

@@ -119,7 +120,8 @@ TEST_F(MessageCenterNotificationManagerTest,

FirstRunNotShownWithPopupsVisible) {

TestingProfile profile;

notification_manager()->Add(GetANotification("test"), &profile);

- message_center()->DisplayedNotification("test");

+ message_center()->DisplayedNotification(

+ "test", message_center::MESSAGE_CENTER);

run_loop()->RunUntilIdle();

EXPECT_FALSE(delegate()->displayed_first_run_balloon());

EXPECT_FALSE(notification_manager()->FirstRunTimerIsActive());