Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2641223003: Proof of concept that CSSPropertyAPI*::parseSingleValue may need more tahn 2 arguments (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index c35a2c59477b1f00a9c604cac18de34a1754e462..dc4585ec2d8eb7d41388945b0b271a37deb2f929 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -1636,22 +1636,6 @@ static CSSValue* consumeImageOrientation(CSSParserTokenRange& range) {
return nullptr;
}
-static CSSValue* consumeCommaSeparatedBackgroundComponent(
- CSSPropertyID unresolvedProperty,
- CSSParserTokenRange& range,
- const CSSParserContext* context) {
- CSSValue* result = nullptr;
- do {
- CSSValue* value =
- CSSPropertyBackgroundComponentUtils::consumeBackgroundComponent(
- unresolvedProperty, range, context);
- if (!value)
- return nullptr;
- CSSPropertyBackgroundComponentUtils::addBackgroundValue(result, value);
- } while (consumeCommaIncludingWhitespace(range));
- return result;
-}
-
static CSSValue* consumeAlignItems(CSSParserTokenRange& range) {
// align-items property does not allow the 'auto' value.
if (identMatches<CSSValueAuto>(range.peek().id()))
@@ -2428,26 +2412,6 @@ const CSSValue* CSSPropertyParser::parseSingleValue(
case CSSPropertyImageOrientation:
ASSERT(RuntimeEnabledFeatures::imageOrientationEnabled());
return consumeImageOrientation(m_range);
- case CSSPropertyBackgroundAttachment:
- case CSSPropertyBackgroundBlendMode:
- case CSSPropertyBackgroundClip:
- case CSSPropertyBackgroundImage:
- case CSSPropertyBackgroundOrigin:
- case CSSPropertyBackgroundPositionX:
- case CSSPropertyBackgroundPositionY:
- case CSSPropertyBackgroundSize:
- case CSSPropertyMaskSourceType:
- case CSSPropertyWebkitBackgroundClip:
- case CSSPropertyWebkitBackgroundOrigin:
- case CSSPropertyWebkitMaskClip:
- case CSSPropertyWebkitMaskComposite:
- case CSSPropertyWebkitMaskImage:
- case CSSPropertyWebkitMaskOrigin:
- case CSSPropertyWebkitMaskPositionX:
- case CSSPropertyWebkitMaskPositionY:
- case CSSPropertyWebkitMaskSize:
- return consumeCommaSeparatedBackgroundComponent(unresolvedProperty,
- m_range, m_context);
case CSSPropertyWebkitMaskRepeatX:
case CSSPropertyWebkitMaskRepeatY:
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698