Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2641173008: [SPv2] Add CSS mask support (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index 77b9cddafecb866ce990f62ccc2089e1fa3b3102..3bc9fb9d94a58b56fb0d5e0dcc327fd010aac0b5 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -2675,6 +2675,9 @@ void PaintLayer::setGroupedMapping(CompositedLayerMapping* groupedMapping,
}
bool PaintLayer::hasCompositedMask() const {
trchen 2017/01/21 01:27:08 Is it obvious to you why this change is needed? I
chrishtr 2017/01/24 01:16:28 Maybe just rename the method to something like app
trchen 2017/02/11 02:35:45 "maskBlendingAppliedByCompositor" to avoid negatio
+ DCHECK(m_layoutObject->hasMask());
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+ return true;
return m_rareData && m_rareData->compositedLayerMapping &&
m_rareData->compositedLayerMapping->hasMaskLayer();
}

Powered by Google App Engine
This is Rietveld 408576698