Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Issue 264113003: Android: Make ContentViewCore's layer a SolidColorLayer (Closed)

Created:
6 years, 7 months ago by no sievers
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, powei
Visibility:
Public.

Description

Android: Make ContentViewCore's layer a SolidColorLayer Change ContentViewCore's container layer to be a SolidColorLayer that uses the view's background color and physical dimensions. But only make it drawable as long as there is no RenderView or we don't have a frame yet to avoid any potential draw (or drawcalc) overhead. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268530

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 6 chunks +20 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
no sievers
ptal
6 years, 7 months ago (2014-05-05 21:31:35 UTC) #1
no sievers
https://codereview.chromium.org/264113003/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java File content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java (left): https://codereview.chromium.org/264113003/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java#oldcode250 content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java:250: return; Regarding |mContentViewCore == null| dtrainor and I were ...
6 years, 7 months ago (2014-05-05 21:35:38 UTC) #2
David Trainor- moved to gerrit
lgtm
6 years, 7 months ago (2014-05-05 22:07:41 UTC) #3
no sievers
+Ted for OWNERS
6 years, 7 months ago (2014-05-06 01:27:51 UTC) #4
Sami
lgtm, and agreed w.r.t. |mContentViewCore == null|.
6 years, 7 months ago (2014-05-06 14:53:12 UTC) #5
Ted C
lgtm
6 years, 7 months ago (2014-05-06 15:11:56 UTC) #6
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 7 months ago (2014-05-06 16:23:20 UTC) #7
no sievers
The CQ bit was unchecked by sievers@chromium.org
6 years, 7 months ago (2014-05-06 16:23:22 UTC) #8
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 7 months ago (2014-05-06 16:23:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/264113003/20001
6 years, 7 months ago (2014-05-06 16:23:56 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 16:25:19 UTC) #11
Message was sent while issue was closed.
Change committed as 268530

Powered by Google App Engine
This is Rietveld 408576698