Brush up localSelectionRectOfPositionTemplate

third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/VisibleUnits.h"
 
 #include "core/dom/Text.h"
 #include "core/editing/EditingTestBase.h"
 #include "core/editing/VisiblePosition.h"
 #include "core/html/TextControlElement.h"
@@ skipping 1979 matching lines @@
        endsOfNodeAreVisuallyDistinctPositionsWithEmptyLayoutChild) {
   // Repro case of crbug.com/584030
   const char* bodyContent =
       "<button><rt><script>document.designMode = 'on'</script></rt></button>";
   setBodyContent(bodyContent);
 
   Node* button = document().querySelector("button");
   EXPECT_TRUE(endsOfNodeAreVisuallyDistinctPositions(button));
 }
 
+TEST_F(VisibleUnitsTest, localSelectionRectOfPositionTemplateNotCrash) {
+  // Repro case of crbug.com/584030
+  const char* bodyContent = "<div>foo<img></div>";

[yosin_UTC9, 2017/01/20 08:00:02]

nit: no need to use |bodyContent|.

[yoichio, 2017/01/20 08:30:41]

Done.

+  setBodyContent(bodyContent);
+
+  Node* node = document().querySelector("img");
+  IntRect rect = absoluteSelectionBoundsOf(VisiblePosition::create(
+      PositionWithAffinity(Position(node, PositionAnchorType::AfterChildren))));
+  EXPECT_EQ(IntRect(9, 9, 1, 1), rect);

[yosin_UTC9, 2017/01/20 08:00:03]

I recommend to use EXPECT_FALSE(rect.isEmpty()) because font size is varied in
platform.

[yoichio, 2017/01/20 08:30:41]

Done.

+}
+
 }  // namespace blink