Brush up localSelectionRectOfPositionTemplate

third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/VisibleUnits.h"
 
 #include "core/dom/Text.h"
 #include "core/editing/EditingTestBase.h"
 #include "core/editing/VisiblePosition.h"
 #include "core/html/TextControlElement.h"
@@ skipping 1979 matching lines @@
        endsOfNodeAreVisuallyDistinctPositionsWithEmptyLayoutChild) {
   // Repro case of crbug.com/584030
   const char* bodyContent =
       "<button><rt><script>document.designMode = 'on'</script></rt></button>";
   setBodyContent(bodyContent);
 
   Node* button = document().querySelector("button");
   EXPECT_TRUE(endsOfNodeAreVisuallyDistinctPositions(button));
 }
 
+TEST_F(VisibleUnitsTest, localSelectionRectOfPositionTemplateNotCrash) {
+  // Repro case of crbug.com/584030
+  const char* bodyContent = "<div>foo<img /></div>";

[yosin_UTC9, 2017/01/20 05:59:53]

No need to have |bodyContent|.

s"<img />"<img>"

No need to have " /" for IMG.

[yoichio, 2017/01/20 08:30:41]

Done.

+  setBodyContent(bodyContent);
+
+  Node* node = document().querySelector("img");
+  IntRect r = absoluteSelectionBoundsOf(VisiblePosition::create(

[yosin_UTC9, 2017/01/20 05:59:53]

nit: Please avoid to use one letter variable name.

[yoichio, 2017/01/20 08:30:41]

Done.

+      PositionWithAffinity(Position(node, PositionAnchorType::AfterChildren))));
+}

[yosin_UTC9, 2017/01/20 05:59:53]

EXPECT_EQ(IntRect(), r) ?

+
 }  // namespace blink