Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(1290)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Issue
264103004
: [Resources] Delete duplicate avatar resources. (Closed)
Created:
6 years, 7 months ago by
noms (inactive)
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
svn://svn.chromium.org/chrome/trunk/src
Visibility:
Public.
More Reviews
Description
[Resources] Delete duplicate avatar resources. The profile avatars are shipped twice, once under /common, and one under the root default_x00_percent/ directories. We should only keep the /common copies. I originally did this in
https://codereview.chromium.org/225813006/
, but then reverted it, so I'm being a good citizen and cleaning it up again :) BUG=NONE TEST=NONE
R=oshima@chromium.org
Committed:
https://src.chromium.org/viewvc/chrome?view=rev&revision=268539
Patch Set 1
#
Created:
6 years, 7 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+78 lines, -78 lines
)
Patch
M
chrome/app/theme/chrome_unscaled_resources.grd
View
1 chunk
+26 lines, -26 lines
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_alien.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_alien_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_awesome.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_awesome_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_burger.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_burger_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_businessman.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_businessman_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_cat.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_cat_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_cupcake.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_cupcake_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_dog.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_dog_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_flower.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_flower_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_aqua.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_aqua_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_blue.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_blue_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_green.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_green_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_orange.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_orange_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_purple.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_purple_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_red.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_red_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_yellow.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_generic_yellow_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_horse.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_horse_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_margarita.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_margarita_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_ninja.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_ninja_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_note.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_note_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_pizza.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_pizza_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_secret_agent.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_secret_agent_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_soccer.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_soccer_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_sun_cloud.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_sun_cloud_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_superhero.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_superhero_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_volley_ball.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_100_percent/profile_avatar_volley_ball_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_alien.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_alien_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_awesome.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_awesome_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_burger.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_burger_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_businessman.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_businessman_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_cat.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_cat_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_cupcake.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_cupcake_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_dog.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_dog_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_flower.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_flower_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_aqua.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_aqua_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_blue.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_blue_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_green.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_green_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_orange.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_orange_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_purple.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_purple_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_red.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_red_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_yellow.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_generic_yellow_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_horse.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_horse_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_margarita.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_margarita_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_ninja.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_ninja_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_note.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_note_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_pizza.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_pizza_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_secret_agent.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_secret_agent_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_soccer.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_soccer_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_sun_cloud.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_sun_cloud_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_superhero.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_superhero_mac.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_volley_ball.png
View
Binary file
0 comments
Download
D
chrome/app/theme/default_200_percent/profile_avatar_volley_ball_mac.png
View
Binary file
0 comments
Download
M
chrome/app/theme/theme_resources.grd
View
1 chunk
+52 lines, -52 lines
0 comments
Download
Messages
Total messages: 3 (0 generated)
Expand Messages
|
Collapse Messages
noms (inactive)
6 years, 7 months ago (2014-05-06 15:36:21 UTC)
#1
oshima
lgtm, thank you!
6 years, 7 months ago (2014-05-06 16:05:25 UTC)
#2
lgtm, thank you!
noms (inactive)
Committed patchset #1 manually as r268539 (presubmit successful).
6 years, 7 months ago (2014-05-06 16:58:21 UTC)
#3
Message was sent while issue was closed.
Committed patchset #1 manually as r268539 (presubmit successful).
Expand Messages
|
Collapse Messages
Issue 264103004: [Resources] Delete duplicate avatar resources. (Closed)
Created 6 years, 7 months ago by noms (inactive)
Modified 6 years, 7 months ago
Reviewers: oshima
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 0
This is Rietveld
408576698