Chromium Code Reviews Chromium Code Reviews
Issue
264103002:
[New Multicolumn] fast/multicol/multicol-with-child-renderLayer-for-input.html puts the textfield i… (Closed)
Description[New Multicolumn] fast/multicol/multicol-with-child-renderLayer-for-input.html puts the textfield in the wrong place
FrameView.cpp changes merged from WebKit. Original patch by David Hyatt <hyatt@apple.com>;.
Reviewed in WebKit by Brady Eidson <beidson@apple.com>;.
Make sure FrameView is patched to pass in the update pagination flag when subtree layout
is done on textfields. It had code for the old multicolumn system but did not have a check
for the new multicolumn system.
Additionally, in Blink we need to avoid switching to a different renderer "container" in RenderBoxModelObject::mapAbsoluteToLocalPoint(), or an assertion will fail at the beginning of RenderBox::offsetFromContainer(). Just include the correct column offset instead and proceed as normally.
BUG=369992
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174871
Patch Set 1 #Patch Set 2 : Just calculate the column offset. Don't jump to a different renderer 'ancestor', as that is unneces… #Patch Set 3 : rebase master #Patch Set 4 : Avoid subpixel differences on Mac. #Patch Set 5 : rebase master #Patch Set 6 : See if this 'fixes' the minor rendering difference on Mac. #
Messages
Total messages: 19 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
