Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: components/omnibox/browser/omnibox_view.h

Issue 2641003002: Show scheme in black and content in gray for data: protocol urls (Closed)
Patch Set: Hoist deemphasis logic Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_view.h
diff --git a/components/omnibox/browser/omnibox_view.h b/components/omnibox/browser/omnibox_view.h
index ba019537e2f831b66a4ba7a6c8621656e82b2f87..d4a81438831d03db5bbed0629e5a27116ac12dbf 100644
--- a/components/omnibox/browser/omnibox_view.h
+++ b/components/omnibox/browser/omnibox_view.h
@@ -259,6 +259,17 @@ class OmniboxView {
OmniboxEditController* controller() { return controller_; }
const OmniboxEditController* controller() const { return controller_; }
+ // Deemphasize parts of the URL to draw attention to whatever best represents
+ // the "identity" of the URL.
+ enum DEEMPHASIZE_COMPONENTS {
Peter Kasting 2017/02/24 01:53:40 This should be CamelCase.
+ EVERYTHING,
+ ALL_BUT_SCHEME,
+ ALL_BUT_HOST,
+ NOTHING,
+ };
+ DEEMPHASIZE_COMPONENTS GetDeemphasis(const base::string16& url_scheme,
+ const bool has_host) const;
+
private:
friend class OmniboxViewMacTest;

Powered by Google App Engine
This is Rietveld 408576698