Show scheme in black and content in gray for data: protocol urls

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"
 
 #include <Carbon/Carbon.h>  // kVK_Return
 
 #include "base/mac/foundation_util.h"
 #include "base/memory/ptr_util.h"
@@ skipping 545 matching lines @@
   bool in_dark_mode = [[field_ window] inIncognitoModeWithSystemTheme];
 
   ApplyTextStyle(attributedString);
 
   // A kinda hacky way to add breaking at periods. This is what Safari does.
   // This works for IDNs too, despite the "en_US".
   [attributedString addAttribute:@"NSLanguage"
                            value:@"en_US_POSIX"
                            range:as_entire_string];
 
-  [attributedString addAttribute:NSForegroundColorAttributeName
-                           value:HostTextColor(in_dark_mode)
-                           range:as_entire_string];
-
   url::Component scheme, host;
   AutocompleteInput::ParseForEmphasizeComponents(
       display_text, ChromeAutocompleteSchemeClassifier(profile_), &scheme,
       &host);
-  bool grey_out_url = display_text.substr(scheme.begin, scheme.len) ==
-      base::UTF8ToUTF16(extensions::kExtensionScheme);
-  if (model()->CurrentTextIsURL() &&
-      (host.is_nonempty() || grey_out_url)) {
+
+  const base::string16 url_scheme =
+      display_text.substr(scheme.begin, scheme.len);
+
+  // As needed, deemphasize parts of the URL to draw attention to
+  // whatever best represents the "identity" of the URL.
+  enum Deemphasize {
+    EVERYTHING,
+    ALL_BUT_SCHEME,
+    ALL_BUT_HOST,
+    NOTHING,
+  } deemphasize = NOTHING;
+
+  if (model()->CurrentTextIsURL()) {
+    // Extension IDs are not human-readable, so deemphasize everything to draw
+    // attention to the human-readable name in the location icon text.
+    if (url_scheme == base::UTF8ToUTF16(extensions::kExtensionScheme))
+      deemphasize = EVERYTHING;
+    // Data URLs are rarely human-readable and can be used for spoofing, so draw
+    // attention to the scheme to emphasize "this is just a bunch of data".
+    else if (url_scheme == base::UTF8ToUTF16(url::kDataScheme))
+      deemphasize = ALL_BUT_SCHEME;
+    // For normal URLs, the host is the best proxy for "identity".
+    else if (host.is_nonempty())
+      deemphasize = ALL_BUT_HOST;
+  }
+
+  [attributedString
+      addAttribute:NSForegroundColorAttributeName
+             value:(deemphasize == NOTHING) ? HostTextColor(in_dark_mode)
+                                            : BaseTextColor(in_dark_mode)
+             range:as_entire_string];
+
+  if (deemphasize == ALL_BUT_SCHEME)

[Peter Kasting, 2017/02/23 01:30:43]

Nit: {}

     [attributedString addAttribute:NSForegroundColorAttributeName
-                             value:BaseTextColor(in_dark_mode)
-                             range:as_entire_string];
-
-    if (!grey_out_url) {
-      [attributedString addAttribute:NSForegroundColorAttributeName
-                               value:HostTextColor(in_dark_mode)
-                               range:ComponentToNSRange(host)];
-    }
-  }
+                             value:HostTextColor(in_dark_mode)
+                             range:ComponentToNSRange(scheme)];
+  else if (deemphasize == ALL_BUT_HOST)
+    [attributedString addAttribute:NSForegroundColorAttributeName
+                             value:HostTextColor(in_dark_mode)
+                             range:ComponentToNSRange(host)];
 
   // TODO(shess): GTK has this as a member var, figure out why.
   // [Could it be to not change if no change?  If so, I'm guessing
   // AppKit may already handle that.]
   const security_state::SecurityLevel security_level =
       controller()->GetToolbarModel()->GetSecurityLevel(false);
 
   // Emphasize the scheme for security UI display purposes (if necessary).
   if (!model()->user_input_in_progress() && model()->CurrentTextIsURL() &&
       scheme.is_nonempty() &&
@@ skipping 490 matching lines @@
                               display_text);
   NSDictionary* notification_info = @{
       NSAccessibilityAnnouncementKey : announcement,
       NSAccessibilityPriorityKey :     @(NSAccessibilityPriorityHigh)
   };
   NSAccessibilityPostNotificationWithUserInfo(
       [field_ window],
       NSAccessibilityAnnouncementRequestedNotification,
       notification_info);
 }