Show scheme in black and content in gray for data: protocol urls

ios/chrome/browser/ui/omnibox/omnibox_view_ios.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_VIEW_IOS_H_
 #define IOS_CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_VIEW_IOS_H_
 
 #import <UIKit/UIKit.h>
 
 #include <memory>
@@ skipping 22 matching lines @@
 class OmniboxViewIOS : public OmniboxView {
  public:
   // Retains |field|.
   OmniboxViewIOS(OmniboxTextFieldIOS* field,
                  WebOmniboxEditController* controller,
                  ios::ChromeBrowserState* browser_state,
                  id<PreloadProvider> prerender,
                  id<OmniboxPopupPositioner> positioner);
   ~OmniboxViewIOS() override;
 
+  static UIColor* GetSecureTextColor(

[Eugene But (OOO till 7-30), 2017/02/28 23:04:38]

Could you please add comments

[elawrence, 2017/03/01 21:49:02]

Done.

+      security_state::SecurityLevel security_level,
+      bool in_dark_mode);

[Eugene But (OOO till 7-30), 2017/02/28 23:04:38]

Do you want to add enum instead of this bool? Otherwise the code will be quite
uninformative at call site: GetSecureTextColor(security_level, true)

[elawrence, 2017/03/01 21:49:02]

I'm inclined to leave this as it is to match Mac's code. Readers who want to see
what this method is doing can easily do so, and it's unlikely that anyone will
ever be passing a bare boolean literal instead of e.g. [field_ incognito], which
is what the only caller of this function does. 

+
   // OmniboxView implementation.
   void OpenMatch(const AutocompleteMatch& match,
                  WindowOpenDisposition disposition,
                  const GURL& alternate_nav_url,
                  const base::string16& pasted_text,
                  size_t selected_line) override;
   base::string16 GetText() const override;
   void SetWindowTextAndCaretPos(const base::string16& text,
                                 size_t caret_pos,
                                 bool update_popup,
@@ skipping 77 matching lines @@
 
  protected:
   int GetOmniboxTextLength() const override;
   void EmphasizeURLComponents() override;
 
  private:
   // Calculates text attributes according to |display_text| and
   // returns them in an autoreleased object.
   NSAttributedString* ApplyTextAttributes(const base::string16& text);
 
+  // Update colors in |attributing_display_string_|.

[Eugene But (OOO till 7-30), 2017/02/28 23:04:38]

Do you want to explain what this method does from the interface perspective,
rather than documenting specific implementation details?

Same comment for the next method

[Eugene But (OOO till 7-30), 2017/02/28 23:04:38]

s/Update/Updates

[Peter Kasting, 2017/03/01 02:39:11]

Wouldn't one expect to find such comments on the base class declaration?  That's
the pattern in most of Chrome.

[Eugene But (OOO till 7-30), 2017/03/01 06:08:08]

Oh, right. I missed that these are override methods. In this case maybe it would
be better to drop these comments at all?

[elawrence, 2017/03/01 21:49:02]

Removed.

+  void SetEmphasis(bool emphasize, gfx::Range range) override;
+
+  // Update color and font for scheme in |attributing_display_string_|.
+  void UpdateSchemeEmphasis(gfx::Range scheme_range) override;
+
   // Removes the query refinement chip from the omnibox.
   void RemoveQueryRefinementChip();
 
   // Returns true if user input should currently be ignored.  On iOS7,
   // modifying the contents of a text field while Siri is pending leads to a
   // UIKit crash.  In order to sidestep that crash, OmniboxViewIOS checks that
   // voice search is not pending before attempting to process user actions that
   // may modify text field contents.
   // TODO(crbug.com/303212): Remove this workaround once the crash is fixed.
   bool ShouldIgnoreUserInputDueToPendingVoiceSearch();
@@ skipping 11 matching lines @@
   NSRange old_selection_;
 
   // TODO(rohitrao): This is a monster hack, needed because closing the popup
   // ends up inadvertently triggering a new round of autocomplete.  Fix the
   // underlying problem, which is that textDidChange: is called when closing the
   // popup, and then remove this hack.  b/5877366.
   BOOL ignore_popup_updates_;
 
   // Bridges delegate method calls from |field_| to C++ land.
   base::scoped_nsobject<AutocompleteTextFieldDelegate> field_delegate_;
+
+  // Temporary pointer to the attributed display string, stored as color and
+  // other emphasis attributes are applied by the superclass.
+  NSMutableAttributedString* attributing_display_string_;
 };
 
 #endif  // IOS_CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_VIEW_IOS_H_