Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 26410003: Add radial_mirror's SK_SCALAR_IS_FLOAT path to radial_repeat too. (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Clear out SK_SCALAR_IS_FLOAT from SkRadialGradient, and merge the logic for radial_mirror and radial_repeat. New radial/repeated bench is 10-20x faster now using float instead of fixed; the rest are unaffected. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11824

Patch Set 1 #

Patch Set 2 : propagate SK_SCALAR_IS_FLOAT through, update 16 bit also, add bench #

Patch Set 3 : non-static versions of template args #

Patch Set 4 : reupload #

Patch Set 5 : reupload #

Patch Set 6 : reupload #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -72 lines) Patch
M bench/GradientBench.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 2 4 chunks +46 lines, -72 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
mtklein
There doesn't seem to be a bench for a radial gradient with a repeat tiling ...
7 years, 2 months ago (2013-10-16 12:32:26 UTC) #1
reed1
There is no more scalar-is-fixed, so that code can be removed
7 years, 2 months ago (2013-10-16 12:38:03 UTC) #2
mtklein
On 2013/10/16 12:38:03, reed1 wrote: > There is no more scalar-is-fixed, so that code can ...
7 years, 2 months ago (2013-10-16 15:12:35 UTC) #3
reed1
is there a change in our gms? lgtm https://codereview.chromium.org/26410003/diff/17001/src/effects/gradients/SkRadialGradient.cpp File src/effects/gradients/SkRadialGradient.cpp (right): https://codereview.chromium.org/26410003/diff/17001/src/effects/gradients/SkRadialGradient.cpp#newcode49 src/effects/gradients/SkRadialGradient.cpp:49: // ...
7 years, 2 months ago (2013-10-16 15:24:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/26410003/17001
7 years, 2 months ago (2013-10-16 18:14:18 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-16 18:59:46 UTC) #6
Message was sent while issue was closed.
Change committed as 11824

Powered by Google App Engine
This is Rietveld 408576698