Inline Document::allowExecutingScripts logic

third_party/WebKit/Source/core/dom/ScriptLoader.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008 Nikolas Zimmermann <zimmermann@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 218 matching lines @@
   if (!isScriptTypeSupported(supportLegacyTypes))
     return false;
 
   if (wasParserInserted) {
     m_parserInserted = true;
     m_forceAsync = false;
   }
 
   m_alreadyStarted = true;
 
+  // FIXME: Eventually we'd like to evaluate scripts which are inserted into a
+  // viewless document but this'll do for now.
+  // See http://bugs.webkit.org/show_bug.cgi?id=5727
   // FIXME: If script is parser inserted, verify it's still in the original
   // document.
   Document& elementDocument = m_element->document();
   Document* contextDocument = elementDocument.contextDocument();
+  if (!contextDocument)
+    return false;
 
-  if (!contextDocument || !contextDocument->allowExecutingScripts(m_element))
+  LocalFrame* contextFrame = contextDocument->executingFrame();
+  if (!contextFrame)
+    return false;
+  LocalFrame* elementFrame = elementDocument.frame();

[Yuki, 2017/01/20 06:15:17]

question: This was elementDocument.executingFrame() before this change.  Is it
okay to change to frame()?

[kouhei (in TOK), 2017/01/20 06:19:03]

No? We still use contextFrame to chck which is executingFrame.

[Yuki, 2017/01/20 06:24:36]

Oops, I was misreading.  Let me revise my question.

Q: We were checking if elementDocument.executingFrame() is nullptr or not (in
Document::allowExecutingScripts) before this change.  But now we don't.  Is it
okay?

If it's okay, then could you declare |elementFrame| just before its use?  We
don't use |elementFrame| until line 308.

+  if (!contextFrame->script().canExecuteScripts(AboutToExecuteScript))
     return false;
 
   if (!isScriptForEventSupported())
     return false;
 
   if (!client->charsetAttributeValue().isEmpty())
     m_characterEncoding = client->charsetAttributeValue();
   else
     m_characterEncoding = elementDocument.characterSet();
 
@@ skipping 34 matching lines @@
              !m_forceAsync) {
     m_pendingScript = PendingScript::create(m_element, m_resource.get());
     m_asyncExecType = ScriptRunner::InOrder;
     contextDocument->scriptRunner()->queueScriptForExecution(this,
                                                              m_asyncExecType);
     // Note that watchForLoad can immediately call pendingScriptFinished.
     m_pendingScript->watchForLoad(this);
   } else if (client->hasSourceAttribute()) {
     m_pendingScript = PendingScript::create(m_element, m_resource.get());
     m_asyncExecType = ScriptRunner::Async;
-    LocalFrame* frame = m_element->document().frame();
-    if (frame) {
-      ScriptState* scriptState = ScriptState::forMainWorld(frame);
-      if (scriptState)
+    if (elementFrame) {
+      // TODO(kouhei): I'm not sure below is correct. I think we should use
+      // contextFrame rather than elementFrame.
+      ScriptState* scriptState = ScriptState::forMainWorld(elementFrame);
+      if (scriptState) {
         ScriptStreamer::startStreaming(
-            m_pendingScript.get(), ScriptStreamer::Async, frame->settings(),
-            scriptState, frame->frameScheduler()->loadingTaskRunner());
+            m_pendingScript.get(), ScriptStreamer::Async,
+            elementFrame->settings(), scriptState,
+            elementFrame->frameScheduler()->loadingTaskRunner());
+      }
     }
     contextDocument->scriptRunner()->queueScriptForExecution(this,
                                                              m_asyncExecType);
     // Note that watchForLoad can immediately call pendingScriptFinished.
     m_pendingScript->watchForLoad(this);
   } else {
     // Reset line numbering for nested writes.
     TextPosition position = elementDocument.isInDocumentWrite()
                                 ? TextPosition()
                                 : scriptStartPosition;
@@ skipping 333 matching lines @@
   if (isHTMLScriptLoader(element))
     return toHTMLScriptElement(element)->loader();
 
   if (isSVGScriptLoader(element))
     return toSVGScriptElement(element)->loader();
 
   return 0;
 }
 
 }  // namespace blink