Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h

Issue 2640983002: Rename paint data structures (Closed)
Patch Set: DrawingDisplayItem Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
index 06429cc56c488c5ef282871a8ff449f082be7bbb..3edea9cc4e61e124bbd64259d99cadfd99387790 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
@@ -10,7 +10,7 @@
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/geometry/FloatPoint.h"
#include "platform/graphics/paint/DisplayItem.h"
-#include "third_party/skia/include/core/SkPicture.h"
+#include "platform/graphics/paint/PaintRecord.h"
#include "third_party/skia/include/core/SkRefCnt.h"
namespace blink {
@@ -20,7 +20,7 @@ class PLATFORM_EXPORT DrawingDisplayItem final : public DisplayItem {
DISABLE_CFI_PERF
DrawingDisplayItem(const DisplayItemClient& client,
Type type,
- sk_sp<const SkPicture> picture,
+ sk_sp<const PaintRecord> picture,
bool knownToBeOpaque = false)
: DisplayItem(client, type, sizeof(*this)),
m_picture(picture && picture->approximateOpCount() ? std::move(picture)
@@ -34,7 +34,8 @@ class PLATFORM_EXPORT DrawingDisplayItem final : public DisplayItem {
WebDisplayItemList*) const override;
bool drawsContent() const override;
- const SkPicture* picture() const { return m_picture.get(); }
+ // TODO(enne): rename this to GetPaintRecord
+ const PaintRecord* picture() const { return m_picture.get(); }
bool knownToBeOpaque() const {
DCHECK(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
@@ -49,7 +50,7 @@ class PLATFORM_EXPORT DrawingDisplayItem final : public DisplayItem {
#endif
bool equals(const DisplayItem& other) const final;
- sk_sp<const SkPicture> m_picture;
+ sk_sp<const PaintRecord> m_picture;
// True if there are no transparent areas. Only used for SlimmingPaintV2.
const bool m_knownToBeOpaque;

Powered by Google App Engine
This is Rietveld 408576698